Refactor BrowserPlugin to reuse sad bitmap from ChildFrameCompositingHelper.

Refactor BrowserPlugin to reuse sad bitmap from ChildFrameCompositingHelper.

Committed: https://crrev.com/f23d2e41c8c5024cfb8367379e50d4c143b0f55e
Cr-Commit-Position: refs/heads/master@{#381045}

[lfg, 2016-03-10 19:18:17]

lfg@chromium.org changed reviewers:
+ fsamuel@chromium.org

[lfg, 2016-03-10 19:18:18]

Hey Fady, please take a look.

[Fady Samuel, 2016-03-10 19:54:07]

lgtm + nit

https://codereview.chromium.org/1784873003/diff/1/content/renderer/browser_pl...
File content/renderer/browser_plugin/browser_plugin.cc (right):

https://codereview.chromium.org/1784873003/diff/1/content/renderer/browser_pl...
content/renderer/browser_plugin/browser_plugin.cc:179: if
(compositing_helper_.get()) {
nit: Is this block necessary?

[lfg, 2016-03-10 19:57:41]

https://codereview.chromium.org/1784873003/diff/1/content/renderer/browser_pl...
File content/renderer/browser_plugin/browser_plugin.cc (right):

https://codereview.chromium.org/1784873003/diff/1/content/renderer/browser_pl...
content/renderer/browser_plugin/browser_plugin.cc:179: if
(compositing_helper_.get()) {
On 2016/03/10 19:54:07, Fady Samuel wrote:
> nit: Is this block necessary?

No. Removed.

[lfg, 2016-03-11 15:20:23]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-03-11 15:20:24]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1784873003/#ps20001
(title: "removing some more dead code")

[commit-bot: I haz the power, 2016-03-11 15:20:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784873003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784873003/20001

[commit-bot: I haz the power, 2016-03-11 15:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 15:52:07]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lfg, 2016-03-14 19:09:15]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-03-14 19:09:15]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1784873003/#ps40001
(title: "enable compositing")

[commit-bot: I haz the power, 2016-03-14 19:09:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784873003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784873003/40001

[commit-bot: I haz the power, 2016-03-14 19:41:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-14 19:42:50]

Description was changed from

==========
Refactor BrowserPlugin to reuse sad bitmap from ChildFrameCompositingHelper.
==========

to

==========
Refactor BrowserPlugin to reuse sad bitmap from ChildFrameCompositingHelper.

Committed: https://crrev.com/f23d2e41c8c5024cfb8367379e50d4c143b0f55e
Cr-Commit-Position: refs/heads/master@{#381045}
==========

[commit-bot: I haz the power, 2016-03-14 19:42:51]

Patchset 3 (id:??) landed as
https://crrev.com/f23d2e41c8c5024cfb8367379e50d4c143b0f55e
Cr-Commit-Position: refs/heads/master@{#381045}