content/renderer/browser_plugin/browser_plugin.h - Issue 1784873003: Refactor BrowserPlugin to reuse sad bitmap from ChildFrameCompositingHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 1784873003: Refactor BrowserPlugin to reuse sad bitmap from ChildFrameCompositingHelper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable compositing Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/browser_plugin/browser_plugin.h

diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h

index 033dcea8e35dedcdaae964bf580173bd683fca96..24ad8e2d9e1fcaaeef1d6c396b247c9c84fc89cb 100644

--- a/content/renderer/browser_plugin/browser_plugin.h

+++ b/content/renderer/browser_plugin/browser_plugin.h

@@ -89,7 +89,7 @@ class CONTENT_EXPORT BrowserPlugin :

bool supportsInputMethod() const override;

bool canProcessDrag() const override;

void updateAllLifecyclePhases() override {}

- void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) override;

+ void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) override {}

void updateGeometry(const blink::WebRect& window_rect,

const blink::WebRect& clip_rect,

const blink::WebRect& unobscured_rect,

@@ -146,7 +146,6 @@ class CONTENT_EXPORT BrowserPlugin :

gfx::Rect view_rect() const { return view_rect_; }

- void ShowSadGraphic();

void UpdateInternalInstanceId();

// IPC message handlers.

« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »