Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: components/version_info/BUILD.gn

Issue 1784783002: Remove obsolete override "ios_extra_version_path". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_info.gypi ('k') | ios/build/util/VERSION » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_info/BUILD.gn
diff --git a/components/version_info/BUILD.gn b/components/version_info/BUILD.gn
index 7f51c0a4376fa2bec869930c383ce43917a5f9d5..6c043e53a912d2d472b60f7e4734380cbb891df4 100644
--- a/components/version_info/BUILD.gn
+++ b/components/version_info/BUILD.gn
@@ -6,12 +6,6 @@ import("//build/config/chrome_build.gni")
import("//chrome/version.gni")
declare_args() {
- if (is_ios) {
- # Path to the file used to override the version PATH level on iOS.
- # Default to ios/build/util/VERSION.
- ios_extra_version_path = "//ios/build/util/VERSION"
- }
-
use_unofficial_version_number = !is_chrome_branded
}
@@ -36,19 +30,4 @@ source_set("version_info") {
process_version("generate_version_info") {
template_file = "version_info_values.h.version"
output = "$target_gen_dir/version_info_values.h"
-
- if (is_ios) {
- # iOS overrides PATCH level of the version with the value from the file
- # named by ios_version_path, however, this needs to be the last argument
- # to the version.py script, so it cannot be added to the sources variable
- # and instead need to be managed manually.
-
- inputs = [
- ios_extra_version_path,
- ]
- extra_args = [
- "-f",
- rebase_path(ios_extra_version_path, root_build_dir),
- ]
- }
}
« no previous file with comments | « components/version_info.gypi ('k') | ios/build/util/VERSION » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698