Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: components/version_info/BUILD.gn

Issue 1784783002: Remove obsolete override "ios_extra_version_path". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/version_info.gypi ('k') | ios/build/util/VERSION » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//chrome/version.gni") 6 import("//chrome/version.gni")
7 7
8 declare_args() { 8 declare_args() {
9 if (is_ios) {
10 # Path to the file used to override the version PATH level on iOS.
11 # Default to ios/build/util/VERSION.
12 ios_extra_version_path = "//ios/build/util/VERSION"
13 }
14
15 use_unofficial_version_number = !is_chrome_branded 9 use_unofficial_version_number = !is_chrome_branded
16 } 10 }
17 11
18 source_set("version_info") { 12 source_set("version_info") {
19 sources = [ 13 sources = [
20 "version_info.cc", 14 "version_info.cc",
21 "version_info.h", 15 "version_info.h",
22 ] 16 ]
23 17
24 deps = [ 18 deps = [
25 ":generate_version_info", 19 ":generate_version_info",
26 "//base", 20 "//base",
27 "//components/strings", 21 "//components/strings",
28 ] 22 ]
29 23
30 if (use_unofficial_version_number) { 24 if (use_unofficial_version_number) {
31 defines = [ "USE_UNOFFICIAL_VERSION_NUMBER" ] 25 defines = [ "USE_UNOFFICIAL_VERSION_NUMBER" ]
32 deps += [ "//ui/base" ] 26 deps += [ "//ui/base" ]
33 } 27 }
34 } 28 }
35 29
36 process_version("generate_version_info") { 30 process_version("generate_version_info") {
37 template_file = "version_info_values.h.version" 31 template_file = "version_info_values.h.version"
38 output = "$target_gen_dir/version_info_values.h" 32 output = "$target_gen_dir/version_info_values.h"
39
40 if (is_ios) {
41 # iOS overrides PATCH level of the version with the value from the file
42 # named by ios_version_path, however, this needs to be the last argument
43 # to the version.py script, so it cannot be added to the sources variable
44 # and instead need to be managed manually.
45
46 inputs = [
47 ios_extra_version_path,
48 ]
49 extra_args = [
50 "-f",
51 rebase_path(ios_extra_version_path, root_build_dir),
52 ]
53 }
54 } 33 }
OLDNEW
« no previous file with comments | « components/version_info.gypi ('k') | ios/build/util/VERSION » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698