Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1784783002: Remove obsolete override "ios_extra_version_path". (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
blundell
CC:
chromium-reviews, Andy Caruso
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete override "ios_extra_version_path". Chrome on iOS is aligning with the rest of Chrome and no longer uses "ios_extra_version_path". Remove it from version_info components and remove the "gclient" hook that generated ios/build/util/CANARY_VERSION. BUG=591419 Committed: https://crrev.com/39e8a6f4d2067be7cad55eb16f699fa2eaa40d11 Cr-Commit-Position: refs/heads/master@{#380394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -121 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
M components/version_info.gypi View 2 chunks +0 lines, -33 lines 0 comments Download
M components/version_info/BUILD.gn View 2 chunks +0 lines, -21 lines 0 comments Download
D ios/build/util/VERSION View 1 chunk +0 lines, -1 line 0 comments Download
D ios/build/util/canary_version.py View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 9 months ago (2016-03-10 04:33:45 UTC) #2
blundell
lgtm
4 years, 9 months ago (2016-03-10 09:56:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784783002/1
4 years, 9 months ago (2016-03-10 10:57:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 12:28:40 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 12:29:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39e8a6f4d2067be7cad55eb16f699fa2eaa40d11
Cr-Commit-Position: refs/heads/master@{#380394}

Powered by Google App Engine
This is Rietveld 408576698