Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 178473006: DM: also run benches once. (Closed)

Created:
6 years, 10 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@dm
Visibility:
Public.

Description

DM: also run benches once. Also: - make GrMemoryPoolBenches threadsafe - some tweaks to various DM code - rename GM::shortName() to getName() to match benches and tests On my desktop, (289 GMs, 617 benches) x 4 configs, 227 tests takes 46s in Debug, 14s in Release. (Still minutes faster than running tests && bench && gm.) GPU singlethreading is definitely the limiting factor again; going to reexamine whether that's helpful to thread it again. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13603

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : working draft #

Patch Set 4 : tweaks #

Patch Set 5 : add note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -206 lines) Patch
M bench/GrMemoryPoolBench.cpp View 1 2 5 chunks +28 lines, -8 lines 0 comments Download
M bench/SkBenchmark.h View 2 chunks +3 lines, -12 lines 0 comments Download
M bench/SkGMBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/benchmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DM.cpp View 1 2 3 4 6 chunks +86 lines, -54 lines 0 comments Download
A dm/DMBenchTask.h View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
A dm/DMBenchTask.cpp View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
M dm/DMCpuTask.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dm/DMCpuTask.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DMGpuTask.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M dm/DMGpuTask.cpp View 1 2 2 chunks +5 lines, -8 lines 0 comments Download
M dm/DMTask.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M dm/DMTask.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M dm/DMTestTask.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMTestTask.cpp View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M dm/DMUtil.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M dm/DMUtil.cpp View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M gm/gm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/gm.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/gmmain.cpp View 1 19 chunks +21 lines, -21 lines 0 comments Download
M gyp/bench.gyp View 3 chunks +1 line, -82 lines 0 comments Download
A gyp/bench.gypi View 1 chunk +88 lines, -0 lines 0 comments Download
M gyp/dm.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M samplecode/GMSampleView.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
Mike, I believe this is what you were asking for last week.
6 years, 9 months ago (2014-02-26 20:13:33 UTC) #1
reed1
I presume the benchiness can be opt'd in or out from the command-line? lgtm
6 years, 9 months ago (2014-02-26 20:30:58 UTC) #2
bsalomon
As I understand it, this won't run GMs-as-benches. We now let GMs know whether they're ...
6 years, 9 months ago (2014-02-26 20:37:45 UTC) #3
mtklein
On 2014/02/26 20:30:58, reed1 wrote: > I presume the benchiness can be opt'd in or ...
6 years, 9 months ago (2014-02-26 20:44:29 UTC) #4
mtklein
On 2014/02/26 20:44:29, mtklein wrote: > On 2014/02/26 20:30:58, reed1 wrote: > > I presume ...
6 years, 9 months ago (2014-02-26 20:56:03 UTC) #5
bsalomon
On 2014/02/26 20:56:03, mtklein wrote: > On 2014/02/26 20:44:29, mtklein wrote: > > On 2014/02/26 ...
6 years, 9 months ago (2014-02-26 21:06:00 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-02-26 21:44:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/178473006/70001
6 years, 9 months ago (2014-02-26 21:45:07 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-26 23:02:07 UTC) #9
Message was sent while issue was closed.
Change committed as 13603

Powered by Google App Engine
This is Rietveld 408576698