Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1784643002: Mojo C++ bindings: remove the utility/ folder. (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, bruening+watch_chromium.org, chromium-reviews, darin (slow to review), glider+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@13_1_remove_thread_dep
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove the utility/ folder. BUG=570102 Committed: https://crrev.com/5077fb33144bbc971146faefd960a671063b4321 Cr-Commit-Position: refs/heads/master@{#380472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1996 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/js/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/test/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M mojo/mojo_base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_edk_tests.gyp View 7 chunks +0 lines, -44 lines 0 comments Download
M mojo/mojo_public.gyp View 2 chunks +0 lines, -32 lines 0 comments Download
D mojo/mojo_public_utility_unittests.isolate View 1 chunk +0 lines, -44 lines 0 comments Download
M mojo/public/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/README.md View 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D mojo/public/cpp/utility/BUILD.gn View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/public/cpp/utility/lib/mutex.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/public/cpp/utility/lib/run_loop.cc View 1 chunk +0 lines, -270 lines 0 comments Download
D mojo/public/cpp/utility/lib/thread.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/public/cpp/utility/lib/thread_local.h View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/public/cpp/utility/lib/thread_local_posix.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/public/cpp/utility/lib/thread_local_win.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/public/cpp/utility/mutex.h View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/public/cpp/utility/run_loop.h View 1 chunk +0 lines, -159 lines 0 comments Download
D mojo/public/cpp/utility/run_loop_handler.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/public/cpp/utility/tests/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/public/cpp/utility/tests/mutex_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D mojo/public/cpp/utility/tests/run_loop_unittest.cc View 1 chunk +0 lines, -428 lines 0 comments Download
D mojo/public/cpp/utility/tests/thread_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D mojo/public/cpp/utility/thread.h View 1 chunk +0 lines, -62 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 9 chunks +0 lines, -42 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +0 lines, -25 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 7 chunks +0 lines, -23 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +0 lines, -27 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/valgrind/chrome_tests.py View 2 chunks +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (9 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 9 months ago (2016-03-09 22:37:53 UTC) #2
Ken Rockot(use gerrit already)
Woohoo! lgtm lgtm lgtm
4 years, 9 months ago (2016-03-09 22:39:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784643002/1
4 years, 9 months ago (2016-03-10 18:43:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/155475)
4 years, 9 months ago (2016-03-10 19:03:25 UTC) #7
yzshen1
+Dirk and Lei for OWNER review. Thanks! Lei: tools/valgrind/chrome_tests.py Dirk: BUILD.gn build/all.gyp build/gn_migration.gypi testing/buildbot/chromium.fyi.json testing/buildbot/chromium.linux.json ...
4 years, 9 months ago (2016-03-10 19:07:15 UTC) #9
Dirk Pranke
lgtm. thestig@ is OOO. This change is trivial, so I'd either TBR= him or cc ...
4 years, 9 months ago (2016-03-10 21:16:36 UTC) #10
yzshen1
On 2016/03/10 21:16:36, Dirk Pranke wrote: > lgtm. > > thestig@ is OOO. This change ...
4 years, 9 months ago (2016-03-10 21:20:14 UTC) #13
Lei Zhang
lgtm
4 years, 9 months ago (2016-03-10 21:25:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784643002/1
4 years, 9 months ago (2016-03-10 21:29:17 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 21:37:51 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 21:39:26 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5077fb33144bbc971146faefd960a671063b4321
Cr-Commit-Position: refs/heads/master@{#380472}

Powered by Google App Engine
This is Rietveld 408576698