Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1784533002: Fix Windows clang compiler complaint (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Windows clang compiler complaint https://codereview.chromium.org/1740533003 ( Initialize font fallback when creating DWrite font manager) seems to have broken the clang/win builds with: ..\..\third_party\skia\src\ports\SkFontMgr_win_dw.cpp(272,11) : error: field 'fLocaleName' will be initialized after field 'fFontFallback' [-Werror,-Wreorder] , fLocaleName(localeNameLength) ^ 1 error generated. I have also created skbug.com/5078 (Add Windows clang bot) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1784533002 Committed: https://skia.googlesource.com/skia/+/08d739c03623cf471db45e8278cf48b3c81c28ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ports/SkFontMgr_win_dw.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
robertphillips
4 years, 9 months ago (2016-03-09 19:49:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784533002/1
4 years, 9 months ago (2016-03-09 19:52:43 UTC) #7
bsalomon
lgtm
4 years, 9 months ago (2016-03-09 19:58:03 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 20:03:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784533002/1
4 years, 9 months ago (2016-03-09 20:04:06 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 20:05:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/08d739c03623cf471db45e8278cf48b3c81c28ed

Powered by Google App Engine
This is Rietveld 408576698