src/ports/SkFontMgr_win_dw.cpp - Issue 1784533002: Fix Windows clang compiler complaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontMgr_win_dw.cpp

Issue 1784533002: Fix Windows clang compiler complaint (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontMgr_win_dw.cpp

diff --git a/src/ports/SkFontMgr_win_dw.cpp b/src/ports/SkFontMgr_win_dw.cpp

index 715bed52912c68da221ea976828aaf512c7c5308..b4e5c1a9f4e229b3535c2584a4a01788aeadff49 100644

--- a/src/ports/SkFontMgr_win_dw.cpp

+++ b/src/ports/SkFontMgr_win_dw.cpp

@@ -268,11 +268,11 @@ public:

SkFontMgr_DirectWrite(IDWriteFactory* factory, IDWriteFontCollection* fontCollection,

WCHAR* localeName, int localeNameLength, IDWriteFontFallback* fallback)

: fFactory(SkRefComPtr(factory))

- , fFontCollection(SkRefComPtr(fontCollection))

- , fLocaleName(localeNameLength)

#if SK_HAS_DWRITE_2_H

, fFontFallback(SkSafeRefComPtr(fallback))

#endif

+ , fFontCollection(SkRefComPtr(fontCollection))

+ , fLocaleName(localeNameLength)

{

#if SK_HAS_DWRITE_2_H

if (!SUCCEEDED(fFactory->QueryInterface(&fFactory2))) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »