Reject dashes from GrAADFR

Reject dashes from GrAADFR

BUG=skia:5082
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1784493004

Committed: https://skia.googlesource.com/skia/+/6266dca7a7a991634d144cbc3a2c6cffefd67454

[bsalomon, 2016-03-10 22:32:44]

Description was changed from

==========
Reject dashes from GrAADFR

BUG=skia:5082
==========

to

==========
Reject dashes from GrAADFR

BUG=skia:5082
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-10 22:33:29]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, jvanverth@google.com

[egdaniel, 2016-03-11 01:00:52]

lgtm with the one suggestion

https://codereview.chromium.org/1784493004/diff/1/src/gpu/batches/GrAADistanc...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/1784493004/diff/1/src/gpu/batches/GrAADistanc...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:114: if
(args.fStroke->isDashed()) {
any reason not to move this check up earlier to avoid doing some unnecessary
work?

[jvanverth1, 2016-03-11 13:49:40]

https://codereview.chromium.org/1784493004/diff/1/src/gpu/batches/GrAADistanc...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/1784493004/diff/1/src/gpu/batches/GrAADistanc...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:114: if
(args.fStroke->isDashed()) {
On 2016/03/11 01:00:52, egdaniel wrote:
> any reason not to move this check up earlier to avoid doing some unnecessary
> work?

The first conditional block seems like a good place to put it.

[bsalomon, 2016-03-11 14:04:51]

On 2016/03/11 13:49:40, jvanverth1 wrote:
>
https://codereview.chromium.org/1784493004/diff/1/src/gpu/batches/GrAADistanc...
> File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):
> 
>
https://codereview.chromium.org/1784493004/diff/1/src/gpu/batches/GrAADistanc...
> src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:114: if
> (args.fStroke->isDashed()) {
> On 2016/03/11 01:00:52, egdaniel wrote:
> > any reason not to move this check up earlier to avoid doing some unnecessary
> > work?
> 
> The first conditional block seems like a good place to put it.

Done

[bsalomon, 2016-03-11 14:04:55]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-11 14:04:55]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1784493004/#ps20001
(title: "Move check earlier")

[commit-bot: I haz the power, 2016-03-11 14:05:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784493004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784493004/20001

[commit-bot: I haz the power, 2016-03-11 14:22:02]

Description was changed from

==========
Reject dashes from GrAADFR

BUG=skia:5082
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Reject dashes from GrAADFR

BUG=skia:5082
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6266dca7a7a991634d144cbc3a2c6cffefd67454
==========

[commit-bot: I haz the power, 2016-03-11 14:22:03]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6266dca7a7a991634d144cbc3a2c6cffefd67454