Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2939)

Unified Diff: src/gpu/batches/GrAADistanceFieldPathRenderer.cpp

Issue 1784493004: Reject dashes from GrAADFR (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Move check earlier Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
diff --git a/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp b/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
index b585de963a97d1e4ab102bfe5d7742a44d687270..4948d29f634cdfc664676f7934de8d8b5f64a4e3 100644
--- a/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
+++ b/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
@@ -86,7 +86,9 @@ bool GrAADistanceFieldPathRenderer::onCanDrawPath(const CanDrawPathArgs& args) c
// TODO: Support inverse fill
if (!args.fShaderCaps->shaderDerivativeSupport() || !args.fAntiAlias ||
SkStrokeRec::kHairline_Style == args.fStroke->getStyle() ||
- args.fPath->isInverseFillType() || args.fPath->isVolatile()) {
+ args.fPath->isInverseFillType() || args.fPath->isVolatile() ||
+ // We don't currently apply the dash or factor it into the DF key. (skbug.com/5082)
+ args.fStroke->isDashed()) {
return false;
}
@@ -109,7 +111,7 @@ bool GrAADistanceFieldPathRenderer::onCanDrawPath(const CanDrawPathArgs& args) c
}
maxDim += extraWidth;
}
-
+
return maxDim <= kMediumMIP && maxDim * maxScale <= 2.0f*kLargeMIP;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698