Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1784383002: Marked tests as Timeout to match actual behavior. (Closed)

Created:
4 years, 9 months ago by eernst
Modified:
4 years, 9 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Marked tests as Timeout to match actual behavior. The test standalone/full_coverage_test.dart was marked in standalone.status as a possible timeout, because I received buildbot failure email that it had timed out. The CL https://codereview.chromium.org/1779173003 that I had landed only added 3 new test files and changed the status files for them, so it is my interpretation that the timeouts are unrelated to my changes. Committed: https://github.com/dart-lang/sdk/commit/f741a16c63a35c0ed8a3757848f21e351d044366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/standalone/standalone.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
eernst
TBR
4 years, 9 months ago (2016-03-11 18:39:57 UTC) #4
eernst
4 years, 9 months ago (2016-03-11 18:40:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f741a16c63a35c0ed8a3757848f21e351d044366 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698