Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1779173003: Adds tests for syntactic support for generic methods. (Closed)

Created:
4 years, 9 months ago by eernst
Modified:
4 years, 9 months ago
Reviewers:
Leaf, regis, Brian Wilkerson
CC:
reviews_dartlang.org, floitsch, hausner, Ivan Posva
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds tests for syntactic support for generic methods. This CL adds tests for syntactic support for declaration of type parameters on methods and named functions, and for passing actual type parameters in invocations. The status files declare all the tests to be `CompiletimeError`s (there is no support for `// AnalyzerOptions=`, so no `--options=..` can be passed to `dartanalyzer`, even though it does succeed with `--options=tests/language/X.options` where `X` is the name of the test). BUG= R=brianwilkerson@google.com, leafp@google.com, regis@google.com Committed: https://github.com/dart-lang/sdk/commit/4dd22a87bb43f2ef2d0ce755d6528cc6a7afc0a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -0 lines) Patch
A tests/language/generic_functions_test.dart View 1 chunk +106 lines, -0 lines 0 comments Download
A tests/language/generic_functions_test.options View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/language/generic_methods_test.dart View 1 chunk +107 lines, -0 lines 0 comments Download
A tests/language/generic_methods_test.options View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/language/generic_sends_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A tests/language/generic_sends_test.options View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
eernst
These tests on generic method parsing should work well with all tools, hence I'm submitting ...
4 years, 9 months ago (2016-03-10 17:53:42 UTC) #2
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-10 18:14:37 UTC) #4
Leaf
lgtm. Would be nice to eventually get tests in there for - local (block level) ...
4 years, 9 months ago (2016-03-10 18:36:04 UTC) #5
regis
LGTM
4 years, 9 months ago (2016-03-10 18:44:00 UTC) #6
eernst
On 2016/03/10 18:36:04, Leaf wrote: > lgtm. > > Would be nice to eventually get ...
4 years, 9 months ago (2016-03-11 09:07:50 UTC) #7
eernst
4 years, 9 months ago (2016-03-11 09:27:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4dd22a87bb43f2ef2d0ce755d6528cc6a7afc0a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698