Chromium Code Reviews

Issue 1784353003: MIPS64: Use BOVC/BNVC for overflow checking on r6. (Closed)

Created:
4 years, 9 months ago by balazs.kilvady
Modified:
4 years, 9 months ago
Reviewers:
ivica.bogosavljevic, gergely.kis.imgtec, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Use BOVC/BNVC for overflow checking on r6. Port 21b331e3ff9f4da302d31627db7ca265adf1a767 BUG= Committed: https://crrev.com/515105a70086dde450d9ff7d9d44ea7352e7a5e4 Cr-Commit-Position: refs/heads/master@{#34731}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+225 lines, -320 lines)
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 6 chunks +30 lines, -28 lines 0 comments
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +3 lines, -7 lines 0 comments
M src/mips/assembler-mips.cc View 2 chunks +0 lines, -2 lines 0 comments
M src/mips64/assembler-mips64.cc View 1 chunk +10 lines, -6 lines 0 comments
M src/mips64/macro-assembler-mips64.h View 2 chunks +30 lines, -28 lines 0 comments
M src/mips64/macro-assembler-mips64.cc View 2 chunks +148 lines, -239 lines 0 comments
M src/mips64/simulator-mips64.cc View 2 chunks +4 lines, -10 lines 0 comments

Messages

Total messages: 8 (3 generated)
balazs.kilvady
4 years, 9 months ago (2016-03-11 17:43:11 UTC) #2
akos.palfi.imgtec
LGTM
4 years, 9 months ago (2016-03-11 17:56:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784353003/1
4 years, 9 months ago (2016-03-11 17:57:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 18:17:58 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 18:19:12 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/515105a70086dde450d9ff7d9d44ea7352e7a5e4
Cr-Commit-Position: refs/heads/master@{#34731}

Powered by Google App Engine