Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/mips/assembler-mips.cc

Issue 1784353003: MIPS64: Use BOVC/BNVC for overflow checking on r6. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/mips64/assembler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 1369 matching lines...) Expand 10 before | Expand all | Expand 10 after
1380 1380
1381 void Assembler::bne(Register rs, Register rt, int16_t offset) { 1381 void Assembler::bne(Register rs, Register rt, int16_t offset) {
1382 BlockTrampolinePoolScope block_trampoline_pool(this); 1382 BlockTrampolinePoolScope block_trampoline_pool(this);
1383 GenInstrImmediate(BNE, rs, rt, offset); 1383 GenInstrImmediate(BNE, rs, rt, offset);
1384 BlockTrampolinePoolFor(1); // For associated delay slot. 1384 BlockTrampolinePoolFor(1); // For associated delay slot.
1385 } 1385 }
1386 1386
1387 1387
1388 void Assembler::bovc(Register rs, Register rt, int16_t offset) { 1388 void Assembler::bovc(Register rs, Register rt, int16_t offset) {
1389 DCHECK(IsMipsArchVariant(kMips32r6)); 1389 DCHECK(IsMipsArchVariant(kMips32r6));
1390 DCHECK(!rs.is(zero_reg));
1391 if (rs.code() >= rt.code()) { 1390 if (rs.code() >= rt.code()) {
1392 GenInstrImmediate(ADDI, rs, rt, offset, CompactBranchType::COMPACT_BRANCH); 1391 GenInstrImmediate(ADDI, rs, rt, offset, CompactBranchType::COMPACT_BRANCH);
1393 } else { 1392 } else {
1394 GenInstrImmediate(ADDI, rt, rs, offset, CompactBranchType::COMPACT_BRANCH); 1393 GenInstrImmediate(ADDI, rt, rs, offset, CompactBranchType::COMPACT_BRANCH);
1395 } 1394 }
1396 } 1395 }
1397 1396
1398 1397
1399 void Assembler::bnvc(Register rs, Register rt, int16_t offset) { 1398 void Assembler::bnvc(Register rs, Register rt, int16_t offset) {
1400 DCHECK(IsMipsArchVariant(kMips32r6)); 1399 DCHECK(IsMipsArchVariant(kMips32r6));
1401 DCHECK(!rs.is(zero_reg));
1402 if (rs.code() >= rt.code()) { 1400 if (rs.code() >= rt.code()) {
1403 GenInstrImmediate(DADDI, rs, rt, offset, CompactBranchType::COMPACT_BRANCH); 1401 GenInstrImmediate(DADDI, rs, rt, offset, CompactBranchType::COMPACT_BRANCH);
1404 } else { 1402 } else {
1405 GenInstrImmediate(DADDI, rt, rs, offset, CompactBranchType::COMPACT_BRANCH); 1403 GenInstrImmediate(DADDI, rt, rs, offset, CompactBranchType::COMPACT_BRANCH);
1406 } 1404 }
1407 } 1405 }
1408 1406
1409 1407
1410 void Assembler::blezalc(Register rt, int16_t offset) { 1408 void Assembler::blezalc(Register rt, int16_t offset) {
1411 DCHECK(IsMipsArchVariant(kMips32r6)); 1409 DCHECK(IsMipsArchVariant(kMips32r6));
(...skipping 1743 matching lines...) Expand 10 before | Expand all | Expand 10 after
3155 3153
3156 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 3154 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
3157 Assembler::FlushICache(isolate, pc, 2 * sizeof(int32_t)); 3155 Assembler::FlushICache(isolate, pc, 2 * sizeof(int32_t));
3158 } 3156 }
3159 } 3157 }
3160 3158
3161 } // namespace internal 3159 } // namespace internal
3162 } // namespace v8 3160 } // namespace v8
3163 3161
3164 #endif // V8_TARGET_ARCH_MIPS 3162 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/mips64/assembler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698