Android Add missing GN data to make base_unittests run with swarming

Android Add missing GN data to make base_unittests run with swarming

BUG=589318

[agrieve, 2016-03-11 18:36:00]

agrieve@chromium.org changed reviewers:
+ thakis@chromium.org

[agrieve, 2016-03-11 18:36:00]

🙈

[Nico, 2016-03-11 21:07:47]

+dpranke to check if my understanding here is correct

https://codereview.chromium.org/1784273003/diff/1/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/1784273003/diff/1/base/BUILD.gn#newcode1894
base/BUILD.gn:1894: "base.isolate",
Why is this needed? GN doesn't use isolate files, instead it uses data sections
which get converted to isolate files during runhooks transparently. I kind of
expected we'd delete all the .isolate files once GN is used everywhere. This
seems to contradict that goal.

[Dirk Pranke, 2016-03-11 21:11:18]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-11 21:11:18]

lgtm , fwiw ...

https://codereview.chromium.org/1784273003/diff/1/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/1784273003/diff/1/base/BUILD.gn#newcode1894
base/BUILD.gn:1894: "base.isolate",
On 2016/03/11 21:07:47, Nico wrote:
> Why is this needed? GN doesn't use isolate files, instead it uses data
sections
> which get converted to isolate files during runhooks transparently. I kind of
> expected we'd delete all the .isolate files once GN is used everywhere. This
> seems to contradict that goal.

See https://bugs.chromium.org/p/chromium/issues/detail?id=589318#c8

Android actually uses the .isolate files two different ways, unfortunately, and
GN/MB currently only addresses one of them. We will eventually need to fix the
android test scripts and/or MB to also address the other, but we need to do this
in the meantime to make swarming at least kinda work.

[Nico, 2016-03-11 21:13:12]

Wow, that seems pretty unfortunate. Rather than making things more unfortunate,
could we instead change things so this isn't needed? It seems we'll have less
technical debt if we address this early, instead of adding all the isolate files
to gn files, and then fixing this later and then reverting all these changes
again.

[Dirk Pranke, 2016-03-11 21:18:46]

On 2016/03/11 21:13:12, Nico wrote:
> Wow, that seems pretty unfortunate. Rather than making things more
unfortunate,
> could we instead change things so this isn't needed? It seems we'll have less
> technical debt if we address this early, instead of adding all the isolate
files
> to gn files, and then fixing this later and then reverting all these changes
> again.

I think we're still working out some of the kinks in how isolates need to work
on Android in order
to address these two use cases, and we need swarming to work in the meantime
(partially
to figure that out, and partially just 'cause we need swarming to work), so I
think we need
to do things in this order, at least for some test steps.

Hopefully we can get a proper fix in before we have to propagate this to every
test step, though.

[agrieve, 2016-03-15 20:08:17]

On 2016/03/11 21:18:46, Dirk Pranke wrote:
> On 2016/03/11 21:13:12, Nico wrote:
> > Wow, that seems pretty unfortunate. Rather than making things more
> unfortunate,
> > could we instead change things so this isn't needed? It seems we'll have
less
> > technical debt if we address this early, instead of adding all the isolate
> files
> > to gn files, and then fixing this later and then reverting all these changes
> > again.
> 
> I think we're still working out some of the kinks in how isolates need to work
> on Android in order
> to address these two use cases, and we need swarming to work in the meantime
> (partially
> to figure that out, and partially just 'cause we need swarming to work), so I
> think we need
> to do things in this order, at least for some test steps.
> 
> Hopefully we can get a proper fix in before we have to propagate this to every
> test step, though.

Abandoned in favour of: https://codereview.chromium.org/1805643002