Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: base/BUILD.gn

Issue 1784273003: Android Add missing GN data to make base_unittests run with swarming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 0b41b0e4a8c93c766501839b81c576d5c8d3cdc9..d3718e4fa8b2f757392c784bc5bd112d3180ebe9 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1889,6 +1889,13 @@ test("base_unittests") {
# TODO(brettw) I think this should not be here, we should not be using
# isolate files.
isolate_file = "base_unittests.isolate"
+ data += [
+ isolate_file,
+ "base.isolate",
Nico 2016/03/11 21:07:47 Why is this needed? GN doesn't use isolate files,
Dirk Pranke 2016/03/11 21:11:18 See https://bugs.chromium.org/p/chromium/issues/de
+ "//third_party/icu/icu.isolate",
+ "//third_party/instrumented_libraries/instrumented_libraries.isolate",
+ "//build/config/win/msvs_dependencies.isolate",
+ ]
}
if (is_ios) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698