content gpu refactor: get rid of gpu related content switches.

content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}

Committed: https://crrev.com/34fb6bacfdd34c536f75504073ce1211898f413b
Cr-Commit-Position: refs/heads/master@{#380988}

[Peng, 2016-03-11 14:52:13]

Description was changed from

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
==========

to

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Peng, 2016-03-11 14:53:27]

Description was changed from

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[Peng, 2016-03-11 19:50:38]

penghuang@chromium.org changed reviewers:
+ piman@chromium.org

[Peng, 2016-03-11 19:50:38]

Hi piman, PTAL. Thanks.

[piman, 2016-03-11 20:43:57]

LGTM after one thing.

https://codereview.chromium.org/1784193003/diff/120001/content/gpu/gpu_child_...
File content/gpu/gpu_child_thread.cc (right):

https://codereview.chromium.org/1784193003/diff/120001/content/gpu/gpu_child_...
content/gpu/gpu_child_thread.cc:196: // process gpu).
Actually, GpuChildThread::OnInitialize is called, so I think you can remove this
code.

[mcasas, 2016-03-11 20:53:27]

mcasas@chromium.org changed reviewers:
+ mcasas@chromium.org

[mcasas, 2016-03-11 20:53:28]

A minor drive-by.

why not remove all the PatchSets 
previous to the one sent for review?

https://codereview.chromium.org/1784193003/diff/120001/gpu/command_buffer/ser...
File gpu/command_buffer/service/gpu_preferences.h (right):

https://codereview.chromium.org/1784193003/diff/120001/gpu/command_buffer/ser...
gpu/command_buffer/service/gpu_preferences.h:44: // Disables HW decode
acceleration for WebRTC.
nit: s/decode/encode/

https://codereview.chromium.org/1784193003/diff/120001/gpu/command_buffer/ser...
gpu/command_buffer/service/gpu_preferences.h:50: bool
enable_accelerated_vpx_decode = false;
How would this square with l.36 
|disable_accelerated_video_decode| ?

My feeling is that the ToT usage of the equivalent
of this flag was deliberately kept generic for some
unknown reason ("...just in case...") while being 
used in just one case, i.e. DXVAVideoDecodeAccelerator. 

I suggest this is is a good moment to correct that 
wrong and make this explicit,e.g.
s/enable_accelerated_vpx_decode/enable_dxva_accelerated_video_decode/

[Peng, 2016-03-11 22:43:16]

https://codereview.chromium.org/1784193003/diff/120001/content/gpu/gpu_child_...
File content/gpu/gpu_child_thread.cc (right):

https://codereview.chromium.org/1784193003/diff/120001/content/gpu/gpu_child_...
content/gpu/gpu_child_thread.cc:196: // process gpu).
On 2016/03/11 20:43:56, piman wrote:
> Actually, GpuChildThread::OnInitialize is called, so I think you can remove
this
> code.

Done.

https://codereview.chromium.org/1784193003/diff/120001/gpu/command_buffer/ser...
File gpu/command_buffer/service/gpu_preferences.h (right):

https://codereview.chromium.org/1784193003/diff/120001/gpu/command_buffer/ser...
gpu/command_buffer/service/gpu_preferences.h:44: // Disables HW decode
acceleration for WebRTC.
On 2016/03/11 20:53:28, mcasas wrote:
> nit: s/decode/encode/

Done.

https://codereview.chromium.org/1784193003/diff/120001/gpu/command_buffer/ser...
gpu/command_buffer/service/gpu_preferences.h:50: bool
enable_accelerated_vpx_decode = false;
On 2016/03/11 20:53:28, mcasas wrote:
> How would this square with l.36 
> |disable_accelerated_video_decode| ?
> 
> My feeling is that the ToT usage of the equivalent
> of this flag was deliberately kept generic for some
> unknown reason ("...just in case...") while being 
> used in just one case, i.e. DXVAVideoDecodeAccelerator. 
> 
> I suggest this is is a good moment to correct that 
> wrong and make this explicit,e.g.
> s/enable_accelerated_vpx_decode/enable_dxva_accelerated_video_decode/
> 

I think it is better to unify those fields in a separate CL. I will file an
issue for it.

[Peng, 2016-03-11 22:47:00]

penghuang@chromium.org changed reviewers:
+ dcheng@chromium.org

[Peng, 2016-03-11 22:47:01]

+dcheng for IPC code.

Hi dcheng, PTAL. Thanks.

[dcheng, 2016-03-13 09:23:35]

lgtm with nits

https://codereview.chromium.org/1784193003/diff/100002/content/common/gpu/med...
File content/common/gpu/media/gpu_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1784193003/diff/100002/content/common/gpu/med...
content/common/gpu/media/gpu_video_decode_accelerator.cc:465: return
make_scoped_ptr<media::VideoDecodeAccelerator>(
Nit: omit template parameter here, it's automatically deduced.

https://codereview.chromium.org/1784193003/diff/100002/content/common/gpu/med...
content/common/gpu/media/gpu_video_decode_accelerator.cc:476: return
make_scoped_ptr<media::VideoDecodeAccelerator>(
Ditto.

https://codereview.chromium.org/1784193003/diff/100002/content/common/gpu/med...
content/common/gpu/media/gpu_video_decode_accelerator.cc:489: return
make_scoped_ptr<media::VideoDecodeAccelerator>(
etc etc here and elsewhere.

[Peng, 2016-03-13 20:33:40]

https://codereview.chromium.org/1784193003/diff/100002/content/common/gpu/med...
File content/common/gpu/media/gpu_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1784193003/diff/100002/content/common/gpu/med...
content/common/gpu/media/gpu_video_decode_accelerator.cc:465: return
make_scoped_ptr<media::VideoDecodeAccelerator>(
On 2016/03/13 09:23:35, dcheng wrote:
> Nit: omit template parameter here, it's automatically deduced.

I tried it without template arg. But it didn't compile.

[Peng, 2016-03-13 20:33:59]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-03-13 20:33:59]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1784193003/#ps100002
(title: "update")

[commit-bot: I haz the power, 2016-03-13 20:34:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784193003/100002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784193003/100002

[commit-bot: I haz the power, 2016-03-13 21:50:33]

Description was changed from

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[commit-bot: I haz the power, 2016-03-13 21:50:35]

Committed patchset #8 (id:100002)

[commit-bot: I haz the power, 2016-03-13 21:52:03]

Description was changed from

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}
==========

[commit-bot: I haz the power, 2016-03-13 21:52:04]

Patchset 8 (id:??) landed as
https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}

[Ken Rockot(use gerrit already), 2016-03-13 23:40:15]

A revert of this CL (patchset #8 id:100002) has been created in
https://codereview.chromium.org/1796633002/ by rockot@chromium.org.

The reason for reverting is: Closed the tree:
https://build.chromium.org/p/chromium/builders/Win/builds/41257/steps/compile....

[Peng, 2016-03-14 14:34:38]

Description was changed from

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}
==========

to

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}
==========

[Peng, 2016-03-14 14:47:16]

On 2016/03/13 23:40:15, Ken Rockot wrote:
> A revert of this CL (patchset #8 id:100002) has been created in
> https://codereview.chromium.org/1796633002/ by mailto:rockot@chromium.org.
> 
> The reason for reverting is: Closed the tree:
>
https://build.chromium.org/p/chromium/builders/Win/builds/41257/steps/compile....

Updated the CL. It should fix the compile issue.

[Peng, 2016-03-14 14:49:41]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-03-14 14:49:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1784193003/#ps150001
(title: "Fix the compile problem on windows")

[commit-bot: I haz the power, 2016-03-14 14:49:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784193003/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784193003/150001

[commit-bot: I haz the power, 2016-03-14 16:41:54]

Description was changed from

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}
==========

to

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}
==========

[commit-bot: I haz the power, 2016-03-14 16:41:55]

Committed patchset #9 (id:150001)

[commit-bot: I haz the power, 2016-03-14 16:43:04]

Description was changed from

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}
==========

to

==========
content gpu refactor: get rid of gpu related content switches.

BUG=590825
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Committed: https://crrev.com/9288ad04012900a9656959f441f4519f4239dccb
Cr-Commit-Position: refs/heads/master@{#380906}

Committed: https://crrev.com/34fb6bacfdd34c536f75504073ce1211898f413b
Cr-Commit-Position: refs/heads/master@{#380988}
==========

[commit-bot: I haz the power, 2016-03-14 16:43:05]

Patchset 9 (id:??) landed as
https://crrev.com/34fb6bacfdd34c536f75504073ce1211898f413b
Cr-Commit-Position: refs/heads/master@{#380988}