Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/threading/worker_pool_win.cc

Issue 1784133002: [tracing] Adding task information to heap profiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix macros again and the builds. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/worker_pool_posix.cc ('k') | base/trace_event/common/trace_event_common.h » ('j') | base/trace_event/heap_profiler_allocation_context_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/worker_pool_win.cc
diff --git a/base/threading/worker_pool_win.cc b/base/threading/worker_pool_win.cc
index 1b0ade5e244c9495570a126b00c080c53943a6ae..46f6a639f2f01b5fefcf47ece1a93da0d6a705b7 100644
--- a/base/threading/worker_pool_win.cc
+++ b/base/threading/worker_pool_win.cc
@@ -21,9 +21,7 @@ base::LazyInstance<ThreadLocalBoolean>::Leaky
DWORD CALLBACK WorkItemCallback(void* param) {
PendingTask* pending_task = static_cast<PendingTask*>(param);
- TRACE_EVENT2("toplevel", "WorkItemCallback::Run",
- "src_file", pending_task->posted_from.file_name(),
- "src_func", pending_task->posted_from.function_name());
+ TRACE_TASK_EXECUTION("WorkerThread::ThreadMain::Run", (*pending_task));
Nico 2016/03/31 16:12:48 nit: no parens around *pending_task
ssid 2016/04/01 04:34:54 moved to macro
g_worker_pool_running_on_this_thread.Get().Set(true);
« no previous file with comments | « base/threading/worker_pool_posix.cc ('k') | base/trace_event/common/trace_event_common.h » ('j') | base/trace_event/heap_profiler_allocation_context_tracker.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698