base/threading/worker_pool_posix.cc - Issue 1784133002: [tracing] Adding task information to heap profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/worker_pool_posix.cc

Issue 1784133002: [tracing] Adding task information to heap profiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix macros again and the builds. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/threading/worker_pool_posix.cc

diff --git a/base/threading/worker_pool_posix.cc b/base/threading/worker_pool_posix.cc

index 53ae4e69627807b209618834104fecf70ed65fc9..dcebe0ab7d2fb704d118a6f797a272ef6c1c0aeb 100644

--- a/base/threading/worker_pool_posix.cc

+++ b/base/threading/worker_pool_posix.cc

@@ -86,9 +86,7 @@ void WorkerThread::ThreadMain() {

PendingTask pending_task = pool_->WaitForTask();

if (pending_task.task.is_null())

break;

- TRACE_EVENT2("toplevel", "WorkerThread::ThreadMain::Run",

- "src_file", pending_task.posted_from.file_name(),

- "src_func", pending_task.posted_from.function_name());

+ TRACE_TASK_EXECUTION("WorkerThread::ThreadMain::Run", pending_task);

tracked_objects::TaskStopwatch stopwatch;

stopwatch.Start();