Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1784073002: Clean attributes of mRoot between tests properly (Closed)

Created:
4 years, 9 months ago by wychen
Modified:
4 years, 9 months ago
Reviewers:
mdjones
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean attributes of mRoot between tests properly This fixes commit https://github.com/chromium/dom-distiller/commit/f5070fd BUG=483172 R=mdjones@chromium.org Committed: fc19f02d8d9d96e5641e8b854d1f8ecae9eb9fa4

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M javatests/org/chromium/distiller/DomDistillerJsTestCase.java View 1 chunk +7 lines, -1 line 2 comments Download
M javatests/org/chromium/distiller/OpenGraphProtocolParserTest.java View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
wychen
PTAL
4 years, 9 months ago (2016-03-11 07:29:29 UTC) #2
mdjones
lgtm +comment https://codereview.chromium.org/1784073002/diff/1/javatests/org/chromium/distiller/DomDistillerJsTestCase.java File javatests/org/chromium/distiller/DomDistillerJsTestCase.java (left): https://codereview.chromium.org/1784073002/diff/1/javatests/org/chromium/distiller/DomDistillerJsTestCase.java#oldcode31 javatests/org/chromium/distiller/DomDistillerJsTestCase.java:31: mRoot.removeAttribute(attrs.get(i).getNodeName()); I'm assuming the problem here was ...
4 years, 9 months ago (2016-03-11 16:58:09 UTC) #3
wychen
https://codereview.chromium.org/1784073002/diff/1/javatests/org/chromium/distiller/DomDistillerJsTestCase.java File javatests/org/chromium/distiller/DomDistillerJsTestCase.java (left): https://codereview.chromium.org/1784073002/diff/1/javatests/org/chromium/distiller/DomDistillerJsTestCase.java#oldcode31 javatests/org/chromium/distiller/DomDistillerJsTestCase.java:31: mRoot.removeAttribute(attrs.get(i).getNodeName()); On 2016/03/11 16:58:09, mdjones wrote: > I'm assuming ...
4 years, 9 months ago (2016-03-11 21:56:32 UTC) #4
wychen
4 years, 9 months ago (2016-03-15 21:54:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fc19f02d8d9d96e5641e8b854d1f8ecae9eb9fa4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698