Clean attributes of mRoot between tests properly

javatests/org/chromium/distiller/DomDistillerJsTestCase.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.distiller;
 
 import com.google.gwt.core.client.JsArray;
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.dom.client.Node;
 import com.google.gwt.dom.client.NodeList;
 
 /**
  * Base test case for all DomDistiller js tests. Ensures that each test starts
  * with a fresh document.
  */
 public class DomDistillerJsTestCase extends JsTestCase {
     protected Element mRoot;
     protected Element mHead;
     protected Element mBody;
 
     @Override
     public void setUp() throws Exception {
         gwtSetUp();
     }
 
     protected void gwtSetUp() throws Exception {
         mRoot = Document.get().getDocumentElement();
         JsArray<Node> attrs = DomUtil.getAttributes(mRoot);
+        String[] attrNames = new String[attrs.length()];
         for (int i = 0; i < attrs.length(); i++) {
-            mRoot.removeAttribute(attrs.get(i).getNodeName());

[mdjones, 2016/03/11 16:58:09]

I'm assuming the problem here was they we were modifying the list size while we
were removing from it.

[wychen, 2016/03/11 21:56:32]

Exactly. attrs is not deeply copied, so it didn't work.

+            attrNames[i] = attrs.get(i).getNodeName();
         }
+        for (int i = 0; i < attrNames.length; i++) {
+            mRoot.removeAttribute(attrNames[i]);
+        }
+        assertEquals(0, DomUtil.getAttributes(mRoot).length());
         NodeList<Node> children = mRoot.getChildNodes();
         for (int i = children.getLength() - 1; i >= 0; i--) {
             children.getItem(i).removeFromParent();
         }
+        assertEquals(0, mRoot.getChildNodes().getLength());
         mHead = Document.get().createElement("head");
         mRoot.appendChild(mHead);
         mBody = Document.get().createElement("body");
         mRoot.appendChild(mBody);
          // With this, the width of chrome window won't affect the layout.
         mRoot.getStyle().setProperty("width", "800px");
     }
 }