Merge xkb related changes.

Merge xkb related changes.




Add back "next_engine" and "prev_engine" config for backward compatibility.


Fix ui to support basic xkb layout switching.


Fix enable_by_default thing.


Add enable_by_default config. When it's true then the newly created input context will be enabled by default.


XKB integration 2nd version - part 1.

[James Su, 2010-04-27 18:43:25]

I just rebuilt my local repository and uploaded CL
http://codereview.chromium.org/1718011 again.

This new CL maintains the backward compatibility.

Regards
James Su

[satorux1, 2010-04-27 21:57:19]

http://codereview.chromium.org/1784007/diff/1/2
File bus/ibusimpl.c (left):

http://codereview.chromium.org/1784007/diff/1/2#oldcode1022
bus/ibusimpl.c:1022: 
Can we just keep this? I think it would be nice to minimize differences from the
upstream.

http://codereview.chromium.org/1784007/diff/1/2#oldcode1079
bus/ibusimpl.c:1079: #if 0
keep ?

http://codereview.chromium.org/1784007/diff/1/2
File bus/ibusimpl.c (right):

http://codereview.chromium.org/1784007/diff/1/2#newcode599
bus/ibusimpl.c:599: ibus->use_sys_layout = TRUE;
Do we need to change the default here? Would be nice to minimize changes from
the upstream as much as possible.

For Chromium OS, we can have the default value in Chromium's preferences, like:

http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/prefe...

prefs->RegisterBooleanPref(prefs::kLanguageUseGlobalEngine, true);

This will be propagated to ibus-daemon when the preferences are initialized.

http://codereview.chromium.org/1784007/diff/1/2#newcode602
bus/ibusimpl.c:602: ibus->use_global_engine = TRUE;
ditto.

http://codereview.chromium.org/1784007/diff/1/8
File setup/setup.ui (left):

http://codereview.chromium.org/1784007/diff/1/8#oldcode135
setup/setup.ui:135: <property name="sensitive">False</property>
What's this change for?

[James Su, 2010-04-27 22:14:57]

http://codereview.chromium.org/1784007/diff/1/2
File bus/ibusimpl.c (left):

http://codereview.chromium.org/1784007/diff/1/2#oldcode1022
bus/ibusimpl.c:1022: 
On 2010/04/27 21:57:19, satorux1 wrote:
> Can we just keep this? I think it would be nice to minimize differences from
the
> upstream.

Will add it back.

http://codereview.chromium.org/1784007/diff/1/2#oldcode1079
bus/ibusimpl.c:1079: #if 0
On 2010/04/27 21:57:19, satorux1 wrote:
> keep ?

Will add it back.

http://codereview.chromium.org/1784007/diff/1/2
File bus/ibusimpl.c (right):

http://codereview.chromium.org/1784007/diff/1/2#newcode599
bus/ibusimpl.c:599: ibus->use_sys_layout = TRUE;
I'm wondering if this preference takes effect on login screen.

On 2010/04/27 21:57:19, satorux1 wrote:
> Do we need to change the default here? Would be nice to minimize changes from
> the upstream as much as possible.
> 
> For Chromium OS, we can have the default value in Chromium's preferences,
like:
> 
>
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/prefe...
> 
> prefs->RegisterBooleanPref(prefs::kLanguageUseGlobalEngine, true);
> 
> This will be propagated to ibus-daemon when the preferences are initialized.

[Yusuke Sato, 2010-04-27 22:55:11]

LGTM with one question.

http://codereview.chromium.org/1784007/diff/1/2
File bus/ibusimpl.c (right):

http://codereview.chromium.org/1784007/diff/1/2#newcode948
bus/ibusimpl.c:948: _context_request_engine_cb (context, engine_name, ibus);
What happens if the previous engine is already removed from the active engine
list?

I'm not sure but wouldn't it be necessary to handle such cases?

[James Su, 2010-04-27 23:23:38]

The CL is updated according to Satoru's comments.

On 2010/04/27 22:55:11, Yusuke Sato wrote:
> LGTM with one question.
> 
> http://codereview.chromium.org/1784007/diff/1/2
> File bus/ibusimpl.c (right):
> 
> http://codereview.chromium.org/1784007/diff/1/2#newcode948
> bus/ibusimpl.c:948: _context_request_engine_cb (context, engine_name, ibus);
> What happens if the previous engine is already removed from the active engine
> list?
It'll fallback to the first engine in the menu.

> 
> I'm not sure but wouldn't it be necessary to handle such cases?

[satorux1, 2010-04-27 23:34:32]

LGTM.

Could you answer my question in setup.ui, regarding sensitive = false?

http://codereview.chromium.org/1784007/diff/8001/9001
File bus/ibusimpl.c (right):

http://codereview.chromium.org/1784007/diff/8001/9001#newcode266
bus/ibusimpl.c:266: }
You can keep the function as-is.