Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1718011: Merge xkb related changes. (Closed)

Created:
10 years, 8 months ago by James Su
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato, satorux1
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Merge xkb related changes. This CL renames the config name of hotkeys: prev_engine -> previous_engine next_engine -> next_engine_in_menu Following new configs are added: general/global_engine general/global_previous_engine general/enable_by_default We should sync the first two configs to cloud. The third one is not useful for us, as it should be TRUE by default. I know that libcros and chrome should be fixed to adapt these new values. I'll send out another CL to fix them and submit these CLs at the same time. Not sure if it's ok to update two dependent parts separately. Seems that there is no way to update them at once. Merge branch 'xkb-integration' into merge-xkb-integration Merge branch 'master' into xkb-integration Fix ui to support basic xkb layout switching. Fix enable_by_default thing. Add enable_by_default config. When it's true then the newly created input context will be enabled by default. XKB integration 2nd version - part 1.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -150 lines) Patch
M bus/ibusimpl.h View 3 chunks +10 lines, -0 lines 0 comments Download
M bus/ibusimpl.c View 25 chunks +270 lines, -54 lines 0 comments Download
M bus/inputcontext.c View 7 chunks +30 lines, -87 lines 0 comments Download
M ibus/bus.py View 1 chunk +3 lines, -0 lines 0 comments Download
M ibus/interface/iibus.py View 1 chunk +3 lines, -1 line 0 comments Download
M setup/main.py View 1 chunk +4 lines, -4 lines 0 comments Download
M setup/setup.ui View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/gtk/panel.py View 5 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
James Su
10 years, 8 months ago (2010-04-23 01:31:58 UTC) #1
Yusuke Sato
Thanks for the change! I have one question: We're not using the python binding for ...
10 years, 8 months ago (2010-04-23 03:09:09 UTC) #2
Yusuke Sato
> We should sync the first two configs to cloud. You might have to modify ...
10 years, 8 months ago (2010-04-23 03:47:42 UTC) #3
James Su
On 2010/04/23 03:09:09, Yusuke Sato wrote: > Thanks for the change! I have one question: ...
10 years, 8 months ago (2010-04-23 18:50:37 UTC) #4
Yusuke Sato
I see. Then I'm fine with merging py files. On 2010/04/23 18:50:37, James Su wrote: ...
10 years, 8 months ago (2010-04-23 18:53:11 UTC) #5
Yusuke Sato
10 years, 8 months ago (2010-04-26 18:19:33 UTC) #6
(Discussed with James and he said he would modify the change so that it would
not break backward compatibility.)

On 2010/04/23 18:53:11, Yusuke Sato wrote:
> I see. Then I'm fine with merging py files.
> 
> On 2010/04/23 18:50:37, James Su wrote:
> > On 2010/04/23 03:09:09, Yusuke Sato wrote:
> > > Thanks for the change! I have one question:
> > > 
> > > We're not using the python binding for ibus as you know. Isn't it possible
> to
> > > merge only C files to make it easier to merge upstream changes?
> > I'd like to keep them for testing purpose. Also, I'm pushing all of these
> > changes into upstream.
> > 
> > > 
> > > On 2010/04/23 01:31:58, James Su wrote:
> > > >

Powered by Google App Engine
This is Rietveld 408576698