Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: build/toolchain/win/setup_toolchain.py

Issue 1783773004: Reland of Change default Windows compiler to VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/get_landmines.py ('k') | build/vs_toolchain.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/setup_toolchain.py
diff --git a/build/toolchain/win/setup_toolchain.py b/build/toolchain/win/setup_toolchain.py
index 1e20387b0b240e987b22e85898c9368d8b0b0b9a..7248ed2479a87e950ccd7e93919fbaa704582796 100644
--- a/build/toolchain/win/setup_toolchain.py
+++ b/build/toolchain/win/setup_toolchain.py
@@ -156,18 +156,18 @@
vc_bin_dir = os.path.realpath(path)
break
- # The Windows SDK include directories must be first. They both have a sal.h,
- # and the SDK one is newer and the SDK uses some newer features from it not
- # present in the Visual Studio one.
- # Having the Windows SDK first is also the only way to control which SDK
- # version is used.
-
- if win_sdk_path:
- additional_includes = [
- os.path.join(win_sdk_path, 'Include', '10.0.10586.0', p)
- for p in ['shared', 'um', 'winrt']]
- additional_includes = os.path.pathsep.join(additional_includes)
- env['INCLUDE'] = additional_includes + os.path.pathsep + env['INCLUDE']
+ # Add extra include directories here that need to be in front of the
+ # installed and packaged include directories. This may be needed in
+ # order to force a particular SDK version, such as to get VS 2013 to use
+ # the Windows 10 SDK. Beware of making the INCLUDE variable excessively
+ # long and be sure to make corresponding changes to build\common.gypi.
+ # Not currently used.
+ #if win_sdk_path:
+ # additional_includes = [
+ # os.path.join(win_sdk_path, 'Include', '10.0.10586.0', p)
+ # for p in ['shared', 'um', 'winrt']]
+ # additional_includes = os.path.pathsep.join(additional_includes)
+ # env['INCLUDE'] = additional_includes + os.path.pathsep + env['INCLUDE']
Nico 2016/03/20 23:54:21 Was this change intentional? We don't check in com
Nico 2016/03/21 17:35:50 I'm deleting it here: https://codereview.chromium.
env_block = _FormatAsEnvironmentBlock(env)
with open('environment.' + cpu, 'wb') as f:
f.write(env_block)
« no previous file with comments | « build/get_landmines.py ('k') | build/vs_toolchain.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698