Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1822633002: Make setup_toolchain.py run on non-Windows. (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make setup_toolchain.py run on non-Windows. Also delete an unused, commented-out block of code. BUG=495204 Committed: https://crrev.com/0917363388c80cb57ee5ceba36dcd047b4bf1d19 Cr-Commit-Position: refs/heads/master@{#382330}

Patch Set 1 #

Total comments: 2

Patch Set 2 : delete unused block #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M build/toolchain/win/setup_toolchain.py View 1 4 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
4 years, 9 months ago (2016-03-21 01:25:45 UTC) #2
scottmg
lgtm https://codereview.chromium.org/1822633002/diff/1/build/toolchain/win/setup_toolchain.py File build/toolchain/win/setup_toolchain.py (right): https://codereview.chromium.org/1822633002/diff/1/build/toolchain/win/setup_toolchain.py#newcode190 build/toolchain/win/setup_toolchain.py:190: #if win_sdk_path: I'm not sure why this is ...
4 years, 9 months ago (2016-03-21 17:30:14 UTC) #3
Nico
Thanks! https://codereview.chromium.org/1822633002/diff/1/build/toolchain/win/setup_toolchain.py File build/toolchain/win/setup_toolchain.py (right): https://codereview.chromium.org/1822633002/diff/1/build/toolchain/win/setup_toolchain.py#newcode190 build/toolchain/win/setup_toolchain.py:190: #if win_sdk_path: On 2016/03/21 17:30:14, scottmg wrote: > ...
4 years, 9 months ago (2016-03-21 17:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822633002/20001
4 years, 9 months ago (2016-03-21 17:36:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 18:20:38 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:22:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0917363388c80cb57ee5ceba36dcd047b4bf1d19
Cr-Commit-Position: refs/heads/master@{#382330}

Powered by Google App Engine
This is Rietveld 408576698