Reland of Change default Windows compiler to VS 2015

Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1778343002/ )

Reason for revert:
Preparing a revert in order to reland VS 2015. The CL is not reading for committing yet.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1740583002/ )
>
> Reason for revert:
> Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg).
>
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > This change was redone in order to fix merge conflicts and because after
> > a few weeks a fresh set of approvals seems reasonable.
> >
> > The original change was landed as crrev.com/1598493004
> >
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b
> > Cr-Commit-Position: refs/heads/master@{#380382}
>
> TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
>
> Committed: https://crrev.com/cb3f85f80a2c146e0e4bf064f02bf68acb274ce5
> Cr-Commit-Position: refs/heads/master@{#380395}

TBR=scottmg@chromium.org,dpranke@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440500, 584782
Committed: https://crrev.com/2b33e7eee5db5f956426dbf664f68bff3fe7daee
Cr-Commit-Position: refs/heads/master@{#380711}

[brucedawson, 2016-03-10 19:53:49]

Created Reland of Change default Windows compiler to VS 2015

[brucedawson, 2016-03-10 19:56:25]

Description was changed from

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1778343002/ )

Reason for revert:
Preparing a revert in order to reland VS 2015. The CL is not reading for
committing yet.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1740583002/ )
> 
> Reason for revert:
> Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg).
>
https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/buil...
> 
> [found] [hashed/size/to hash] [looked up/to lookup] [uploaded/size/to
upload/size]
> 04:10:31.512494 Root: E:\b\build\slave\Win8_GN__dbg_\build\src
> 04:10:31.513479 Root: E:\b\build\slave\Win8_GN__dbg_\build\src
> 
> events_unittests  GetFileAttributesEx
E:\b\build\slave\Win8_GN__dbg_\build\src\out\Debug\msvcp120d.dll: The system
cannot find the file specified.
> 04:10:31.988532
PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\content\test\data\) =
1574 files
> 04:10:32.060523
PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\media\test\data\) = 233
files
> 04:10:32.435549
PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\net\data\) = 974 files
> 04:10:32.464549
PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\net\tools\testserver\) =
11 files
> [2843] [6/29.0Mib/39] [0/6] [0/0b/0/0b] 1s
> 04:10:32.505555
PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\third_party\pyftpdlib\) =
37 files
> 04:10:32.539557
PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\third_party\pywebsocket\)
= 99 files
> 04:10:32.578571
PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\third_party\tlslite\) =
105 files
> 
> content_browsertests  GetFileAttributesEx
E:\b\build\slave\Win8_GN__dbg_\build\src\out\Debug\msvcp120d.dll: The system
cannot find the file specified.
> Hits    :     0 (0b)
> Misses  :     0 (0b)
> Duration: 1.301s
> isolate: GetFileAttributesEx
E:\b\build\slave\Win8_GN__dbg_\build\src\out\Debug\msvcp120d.dll: The system
cannot find the file specified.
> step returned non-zero exit code: 1
> 
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > This change was redone in order to fix merge conflicts and because after
> > a few weeks a fresh set of approvals seems reasonable.
> >
> > The original change was landed as crrev.com/1598493004
> >
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b
> > Cr-Commit-Position: refs/heads/master@{#380382}
> 
> TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
> 
> Committed: https://crrev.com/cb3f85f80a2c146e0e4bf064f02bf68acb274ce5
> Cr-Commit-Position: refs/heads/master@{#380395}

TBR=scottmg@chromium.org,dpranke@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440500, 584782
==========

to

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1778343002/ )

Reason for revert:
Preparing a revert in order to reland VS 2015. The CL is not reading for
committing yet.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1740583002/ )
> 
> Reason for revert:
> Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg).
> 
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > This change was redone in order to fix merge conflicts and because after
> > a few weeks a fresh set of approvals seems reasonable.
> >
> > The original change was landed as crrev.com/1598493004
> >
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b
> > Cr-Commit-Position: refs/heads/master@{#380382}
> 
> TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
> 
> Committed: https://crrev.com/cb3f85f80a2c146e0e4bf064f02bf68acb274ce5
> Cr-Commit-Position: refs/heads/master@{#380395}

TBR=scottmg@chromium.org,dpranke@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440500, 584782
==========

[brucedawson, 2016-03-11 19:48:54]

On 2016/03/10 19:53:49, brucedawson wrote:
> Created Reland of Change default Windows compiler to VS 2015

All known blockers have been resolved. Committing reland in ~five minutes...

[brucedawson, 2016-03-11 19:53:27]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-03-11 19:54:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783773004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783773004/1

[commit-bot: I haz the power, 2016-03-11 19:55:36]

Description was changed from

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1778343002/ )

Reason for revert:
Preparing a revert in order to reland VS 2015. The CL is not reading for
committing yet.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1740583002/ )
> 
> Reason for revert:
> Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg).
> 
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > This change was redone in order to fix merge conflicts and because after
> > a few weeks a fresh set of approvals seems reasonable.
> >
> > The original change was landed as crrev.com/1598493004
> >
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b
> > Cr-Commit-Position: refs/heads/master@{#380382}
> 
> TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
> 
> Committed: https://crrev.com/cb3f85f80a2c146e0e4bf064f02bf68acb274ce5
> Cr-Commit-Position: refs/heads/master@{#380395}

TBR=scottmg@chromium.org,dpranke@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440500, 584782
==========

to

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1778343002/ )

Reason for revert:
Preparing a revert in order to reland VS 2015. The CL is not reading for
committing yet.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1740583002/ )
> 
> Reason for revert:
> Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg).
> 
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > This change was redone in order to fix merge conflicts and because after
> > a few weeks a fresh set of approvals seems reasonable.
> >
> > The original change was landed as crrev.com/1598493004
> >
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b
> > Cr-Commit-Position: refs/heads/master@{#380382}
> 
> TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
> 
> Committed: https://crrev.com/cb3f85f80a2c146e0e4bf064f02bf68acb274ce5
> Cr-Commit-Position: refs/heads/master@{#380395}

TBR=scottmg@chromium.org,dpranke@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440500, 584782
==========

[commit-bot: I haz the power, 2016-03-11 19:55:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-11 19:56:44]

Description was changed from

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1778343002/ )

Reason for revert:
Preparing a revert in order to reland VS 2015. The CL is not reading for
committing yet.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1740583002/ )
> 
> Reason for revert:
> Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg).
> 
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > This change was redone in order to fix merge conflicts and because after
> > a few weeks a fresh set of approvals seems reasonable.
> >
> > The original change was landed as crrev.com/1598493004
> >
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b
> > Cr-Commit-Position: refs/heads/master@{#380382}
> 
> TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
> 
> Committed: https://crrev.com/cb3f85f80a2c146e0e4bf064f02bf68acb274ce5
> Cr-Commit-Position: refs/heads/master@{#380395}

TBR=scottmg@chromium.org,dpranke@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440500, 584782
==========

to

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1778343002/ )

Reason for revert:
Preparing a revert in order to reland VS 2015. The CL is not reading for
committing yet.

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1740583002/ )
>
> Reason for revert:
> Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg).
>
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015
> >
> > The change to get_landmines.py is there because modifying this file
> > affects analyze behavior so that all tests run. Changing the printed
> > message is purely a side effect.
> >
> > This change also removes some redundant INCLUDE paths. These are
> > unnecessary when building with VS 2015 (because it defaults to the
> > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > problematically long).
> >
> > This change was redone in order to fix merge conflicts and because after
> > a few weeks a fresh set of approvals seems reasonable.
> >
> > The original change was landed as crrev.com/1598493004
> >
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b
> > Cr-Commit-Position: refs/heads/master@{#380382}
>
> TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
>
> Committed: https://crrev.com/cb3f85f80a2c146e0e4bf064f02bf68acb274ce5
> Cr-Commit-Position: refs/heads/master@{#380395}

TBR=scottmg@chromium.org,dpranke@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440500, 584782

Committed: https://crrev.com/2b33e7eee5db5f956426dbf664f68bff3fe7daee
Cr-Commit-Position: refs/heads/master@{#380711}
==========

[commit-bot: I haz the power, 2016-03-11 19:56:45]

Patchset 1 (id:??) landed as
https://crrev.com/2b33e7eee5db5f956426dbf664f68bff3fe7daee
Cr-Commit-Position: refs/heads/master@{#380711}

[Nico, 2016-03-20 23:54:20]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-20 23:54:21]

https://codereview.chromium.org/1783773004/diff/1/build/toolchain/win/setup_t...
File build/toolchain/win/setup_toolchain.py (right):

https://codereview.chromium.org/1783773004/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:170: #  env['INCLUDE'] =
additional_includes + os.path.pathsep + env['INCLUDE']
Was this change intentional? We don't check in commented-out code usually – can
this block just be deleted?

[Nico, 2016-03-21 17:35:50]

https://codereview.chromium.org/1783773004/diff/1/build/toolchain/win/setup_t...
File build/toolchain/win/setup_toolchain.py (right):

https://codereview.chromium.org/1783773004/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:170: #  env['INCLUDE'] =
additional_includes + os.path.pathsep + env['INCLUDE']
On 2016/03/20 23:54:21, Nico wrote:
> Was this change intentional? We don't check in commented-out code usually –
can
> this block just be deleted?

I'm deleting it here: https://codereview.chromium.org/1822633002