Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1783693003: Call OnDecorationsChanged when the save card icon is updated. (Closed)

Created:
4 years, 9 months ago by Justin Donnelly
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Call OnDecorationsChanged when the save card icon is updated. Failing to do so results in several bugs: - The save card icon sometimes fails to appear. - The cursor rect for the omnibox isn't updated, resulting in the wrong mouse icon being shown when hovering over the save card icon. - The save card icon tooltip doesn't appear. BUG=566271 Review URL: https://codereview.chromium.org/1760273002 Cr-Commit-Position: refs/heads/master@{#379629} (cherry picked from commit dff48ce2ab293d4f1db86e6f15a6a06f7a01699e) Committed: https://chromium.googlesource.com/chromium/src/+/227cc13e10ee044a49b02c0a380315a8ab18b530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Justin Donnelly
4 years, 9 months ago (2016-03-10 16:24:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
227cc13e10ee044a49b02c0a380315a8ab18b530.

Powered by Google App Engine
This is Rietveld 408576698