Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1760273002: Call OnDecorationsChanged when the save card icon is updated. (Closed)

Created:
4 years, 9 months ago by Justin Donnelly
Modified:
4 years, 9 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call OnDecorationsChanged when the save card icon is updated. Failing to do so results in several bugs: - The save card icon sometimes fails to appear. - The cursor rect for the omnibox isn't updated, resulting in the wrong mouse icon being shown when hovering over the save card icon. - The save card icon tooltip doesn't appear. BUG=566271 Committed: https://crrev.com/dff48ce2ab293d4f1db86e6f15a6a06f7a01699e Cr-Commit-Position: refs/heads/master@{#379629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Justin Donnelly
4 years, 9 months ago (2016-03-03 23:04:49 UTC) #2
groby-ooo-7-16
lgtm
4 years, 9 months ago (2016-03-07 19:34:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760273002/1
4 years, 9 months ago (2016-03-07 19:40:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 20:18:19 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 20:21:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dff48ce2ab293d4f1db86e6f15a6a06f7a01699e
Cr-Commit-Position: refs/heads/master@{#379629}

Powered by Google App Engine
This is Rietveld 408576698