third_party/WebKit/Source/core/loader/FrameFetchContext.cpp - Issue 1783653002: save-data header value gets appended on page refreshes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 1783653002: save-data header value gets appended on page refreshes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/data_saver/data_saver_browsertest.cc ('k') | third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

index 5bdfcb105a9e4b151336647a87ae36f5a2458e66..21f219ea0956532ff7441293f5fc8ee42631320c 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

@@ -119,8 +119,11 @@ void FrameFetchContext::addAdditionalRequestHeaders(ResourceRequest& request, Fe

if (!request.url().isEmpty() && !request.url().protocolIsInHTTPFamily())

return;

+ if (frame()->loader().loadType() == FrameLoadTypeReload)

+ request.clearHTTPHeaderField("Save-Data");

if (frame()->settings() && frame()->settings()->dataSaverEnabled())

- request.addHTTPHeaderField("Save-Data", "on");

+ request.setHTTPHeaderField("Save-Data", "on");

frame()->loader().applyUserAgent(request);

}