Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Unified Diff: chrome/browser/data_saver/data_saver_browsertest.cc

Issue 1783653002: save-data header value gets appended on page refreshes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/data_saver/data_saver_browsertest.cc
diff --git a/chrome/browser/data_saver/data_saver_browsertest.cc b/chrome/browser/data_saver/data_saver_browsertest.cc
index 3c8e38264cd64ee6f8349ca392fbdceb1cb52d4f..09290309fe024beb932f0017d3c1d62174f4820f 100644
--- a/chrome/browser/data_saver/data_saver_browsertest.cc
+++ b/chrome/browser/data_saver/data_saver_browsertest.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -14,6 +15,8 @@
#include "content/public/test/browser_test_base.h"
#include "content/public/test/browser_test_utils.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
+#include "net/test/embedded_test_server/http_request.h"
+#include "net/test/embedded_test_server/http_response.h"
class DataSaverBrowserTest : public InProcessBrowserTest {
protected:
@@ -45,3 +48,59 @@ IN_PROC_BROWSER_TEST_F(DataSaverBrowserTest, DataSaverDisabled) {
EnableDataSaver(false);
VerifySaveDataHeader("None");
}
+
+class DataSaverWithServerBrowserTest : public InProcessBrowserTest {
+ protected:
+ void Init() {
+ test_server_.reset(new net::EmbeddedTestServer());
+ test_server_->RegisterRequestHandler(
+ base::Bind(&DataSaverWithServerBrowserTest::VerifySaveDataHeader,
+ base::Unretained(this)));
+ test_server_->ServeFilesFromSourceDirectory("chrome/test/data");
+ }
+ void EnableDataSaver(bool enabled) {
+ PrefService* prefs = browser()->profile()->GetPrefs();
+ prefs->SetBoolean(prefs::kDataSaverEnabled, enabled);
+ }
+
+ scoped_ptr<net::test_server::HttpResponse> VerifySaveDataHeader(
+ const net::test_server::HttpRequest& request) {
+ auto save_data_header_it = request.headers.find("save-data");
+
+ if (!expected_save_data_header_.empty()) {
+ EXPECT_TRUE(save_data_header_it != request.headers.end());
+ EXPECT_EQ(expected_save_data_header_, save_data_header_it->second);
+ } else {
+ EXPECT_TRUE(save_data_header_it == request.headers.end());
+ }
+ return scoped_ptr<net::test_server::HttpResponse>();
+ }
+
+ scoped_ptr<net::EmbeddedTestServer> test_server_;
+ std::string expected_save_data_header_;
+};
+
+IN_PROC_BROWSER_TEST_F(DataSaverWithServerBrowserTest, ReloadPage) {
+ Init();
+ ASSERT_TRUE(test_server_->Start());
+ EnableDataSaver(true);
+
+ expected_save_data_header_ = "on";
+ ui_test_utils::NavigateToURL(browser(),
+ test_server_->GetURL("/google/google.html"));
+
+ // Reload the webpage and expect the main and the subresources will get the
+ // correct save-data header.
+ expected_save_data_header_ = "on";
+ chrome::Reload(browser(), CURRENT_TAB);
+ content::WaitForLoadStop(
+ browser()->tab_strip_model()->GetActiveWebContents());
+
+ // Reload the webpage with data saver disabled, and expect all the resources
+ // will get no save-data header.
+ EnableDataSaver(false);
+ expected_save_data_header_ = "";
+ chrome::Reload(browser(), CURRENT_TAB);
+ content::WaitForLoadStop(
+ browser()->tab_strip_model()->GetActiveWebContents());
+}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698