Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 17836007: Move webkit_common to its own gyp file (Closed)

Created:
7 years, 5 months ago by jamesr
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move webkit_common to its own gyp file This pulls the webkit_common target out of webkit_support.gyp so that we can extract targets that depend on this out of webkit_support.gyp without creating cycles between gyp files, which is forbidden on darwin. Depends on https://codereview.chromium.org/17472006/ to move the resources target. R=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -98 lines) Patch
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + webkit/common/webkit_common.gyp View 1 chunk +4 lines, -1 line 0 comments Download
D webkit/common/webkit_common.gypi View 1 chunk +0 lines, -88 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 3 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/webkit_plugins.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/support/webkit_support.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
I think you'll need this to create webkit_browser if it depends on webkit_common
7 years, 5 months ago (2013-06-27 00:11:06 UTC) #1
darin (slow to review)
LGTM On Jun 26, 2013 5:11 PM, <jamesr@chromium.org> wrote: > Reviewers: darin, > > Message: ...
7 years, 5 months ago (2013-06-27 02:57:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/17836007/1
7 years, 5 months ago (2013-07-04 00:24:46 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-04 02:50:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/17836007/1
7 years, 5 months ago (2013-07-09 01:57:29 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=173527
7 years, 5 months ago (2013-07-09 07:49:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/17836007/1
7 years, 5 months ago (2013-07-09 07:54:12 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 08:03:46 UTC) #8
Message was sent while issue was closed.
Change committed as 210514

Powered by Google App Engine
This is Rietveld 408576698