Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1783423002: Marked tests as Timeout to match actual behavior. (Closed)

Created:
4 years, 9 months ago by eernst
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Marked tests as Timeout to match actual behavior. The tests service/{vm_timeline_events_test,coverage_test}.dart were marked in service.status as possible timeouts, because I received buildbot failure email that they had timed out. The CL https://codereview.chromium.org/1779173003 that I had landed only added 3 new test files and changed the status files for them, so it is my interpretation that the timeouts are unrelated to my changes. Committed: https://github.com/dart-lang/sdk/commit/2ee2fdb27c67b8cfb43c4960841097b985daf2ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/observatory/tests/service/service.status View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
eernst
TBR
4 years, 9 months ago (2016-03-11 18:29:40 UTC) #2
eernst
Committed patchset #1 (id:1) manually as 2ee2fdb27c67b8cfb43c4960841097b985daf2ee (presubmit successful).
4 years, 9 months ago (2016-03-11 18:31:04 UTC) #4
Cutch
On 2016/03/11 18:31:04, eernst wrote: > Committed patchset #1 (id:1) manually as > 2ee2fdb27c67b8cfb43c4960841097b985daf2ee (presubmit ...
4 years, 9 months ago (2016-03-11 18:47:04 UTC) #5
eernst
4 years, 9 months ago (2016-03-11 19:10:49 UTC) #6
Message was sent while issue was closed.
On 2016/03/11 18:47:04, Cutch wrote:
> On 2016/03/11 18:31:04, eernst wrote:
> > Committed patchset #1 (id:1) manually as
> > 2ee2fdb27c67b8cfb43c4960841097b985daf2ee (presubmit successful).
> 
> Hi,
> 
> Please revert this change as we don't hide these failures on the bots.

OK, I followed Florian L's advice on this, but it's reverted now.

Powered by Google App Engine
This is Rietveld 408576698