Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: public/platform/WebFileSystem.h

Issue 178333009: Handle has_more correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: ifdef hack Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebFileSystem.h
diff --git a/public/platform/WebFileSystem.h b/public/platform/WebFileSystem.h
index c89c6d1426c7d07fdf1675821043f1f9743d2cf0..aaf43a3aa4165029c7b9dd640f1997e986969ab0 100644
--- a/public/platform/WebFileSystem.h
+++ b/public/platform/WebFileSystem.h
@@ -36,6 +36,9 @@
#include "WebFileSystemType.h"
#include "WebURL.h"
+// TODO(hashimoto): Remove this #define.
kinuko 2014/03/06 13:13:38 nit: "TODO(hashimoto):" -> "FIXME:" in blink
hashimoto 2014/03/07 05:21:26 Done.
+#define READ_DIRECTORY_RETURNS_INT
+
namespace blink {
class WebFileWriter;
@@ -136,7 +139,7 @@ public:
// Reads directory entries of a given directory at |path|.
// WebFileSystemCallbacks::didReadDirectory() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
kinuko 2014/03/06 13:13:38 Can you add a comment about the return value?
hashimoto 2014/03/07 05:21:26 Done.
- virtual void readDirectory(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual int readDirectory(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); return 0; }
// Creates a WebFileWriter that can be used to write to the given file.
// WebFileSystemCallbacks::didCreateFileWriter() must be called with the created WebFileWriter when the operation is completed successfully.
@@ -153,6 +156,10 @@ public:
// WebFileSystemCallbacks::didFail() must be called otherwise.
virtual void createSnapshotFileAndReadMetadata(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ // Waits for additional results returned for the method call.
+ // |callbacksId| must be the value returned by the original method call.
kinuko 2014/03/06 13:13:38 Can you add a comment about the return value? (Tho
hashimoto 2014/03/07 05:21:26 Done.
+ virtual bool waitForAdditionalResult(int callbacksId) { BLINK_ASSERT_NOT_REACHED(); return false; }
+
protected:
virtual ~WebFileSystem() { }
};

Powered by Google App Engine
This is Rietveld 408576698