Handle has_more correctly

public/platform/WebFileSystem.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #ifndef WebFileSystem_h
 #define WebFileSystem_h
 
 #include "WebCommon.h"
 #include "WebFileSystemCallbacks.h"
 #include "WebFileSystemType.h"
 #include "WebURL.h"
 
+// TODO(hashimoto): Remove this #define.

[kinuko, 2014/03/06 13:13:38]

nit: "TODO(hashimoto):" -> "FIXME:" in blink

[hashimoto, 2014/03/07 05:21:26]

Done.

+#define READ_DIRECTORY_RETURNS_INT
+
 namespace blink {
 
 class WebFileWriter;
 class WebFileWriterClient;
 
 class WebFileSystem {
 public:
     enum Type {
         TypeTemporary,
         TypePersistent,
@@ skipping 79 matching lines @@
     // WebFileSystemCallbacks::didFail() must be called otherwise.
     virtual void fileExists(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
 
     // Checks if a directory exists at a given |path|.
     // WebFileSystemCallbacks::didSucceed() must be called when the operation is completed successfully.
     // WebFileSystemCallbacks::didFail() must be called otherwise.
     virtual void directoryExists(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
 
     // Reads directory entries of a given directory at |path|.
     // WebFileSystemCallbacks::didReadDirectory() must be called when the operation is completed successfully.
     // WebFileSystemCallbacks::didFail() must be called otherwise.

[kinuko, 2014/03/06 13:13:38]

Can you add a comment about the return value?

[hashimoto, 2014/03/07 05:21:26]

Done.

-    virtual void readDirectory(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+    virtual int readDirectory(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); return 0; }
 
     // Creates a WebFileWriter that can be used to write to the given file.
     // WebFileSystemCallbacks::didCreateFileWriter() must be called with the created WebFileWriter when the operation is completed successfully.
     // WebFileSystemCallbacks::didFail() must be called otherwise.
     virtual void createFileWriter(const WebURL& path, WebFileWriterClient*, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
 
     // Creates a snapshot file for a given file specified by |path|. It returns the metadata of the created snapshot file.
     // The returned metadata should include a local platform path to the snapshot image.
     // In local filesystem cases the backend may simply return the metadata of the file itself (as well as readMetadata does), while in
     // remote filesystem case the backend may download the file into a temporary snapshot file and return the metadata of the temporary file.
     // The returned metadata is used to create a File object for the |path|.
     // The snapshot file is supposed to be deleted when the last reference to a WebCore::File referring to it's path is dropped.
     // WebFileSystemCallbacks::didCreateSnapshotFile() with the metadata of the snapshot file must be called when the operation is completed successfully.
     // WebFileSystemCallbacks::didFail() must be called otherwise.
     virtual void createSnapshotFileAndReadMetadata(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
 
+    // Waits for additional results returned for the method call.
+    // |callbacksId| must be the value returned by the original method call.

[kinuko, 2014/03/06 13:13:38]

Can you add a comment about the return value? (Though it looks we don't use it)

[hashimoto, 2014/03/07 05:21:26]

Done.

+    virtual bool waitForAdditionalResult(int callbacksId) { BLINK_ASSERT_NOT_REACHED(); return false; }
+
 protected:
     virtual ~WebFileSystem() { }
 };
 
 } // namespace blink
 
 #endif