Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1783313003: [heap] Use struct Entry to fill inlined promotion queue entries. (Closed)

Created:
4 years, 9 months ago by Hannes Payer (out of office)
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use struct Entry to fill inlined promotion queue entries. BUG=chromium:561449 LOG=n Committed: https://crrev.com/c0d8036e913b91664093700b07f48e744e2b4335 Cr-Commit-Position: refs/heads/master@{#34722}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
M src/heap/heap.h View 1 2 3 4 4 chunks +18 lines, -13 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 5 chunks +12 lines, -11 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
https://codereview.chromium.org/1783313003/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1783313003/diff/20001/src/heap/heap.cc#newcode1584 src/heap/heap.cc:1584: struct Entry* entry = reinterpret_cast<struct Entry*>(head_start); I think we ...
4 years, 9 months ago (2016-03-11 12:16:55 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/1783313003/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1783313003/diff/20001/src/heap/heap.cc#newcode1584 src/heap/heap.cc:1584: struct Entry* entry = reinterpret_cast<struct Entry*>(head_start); On 2016/03/11 12:16:55, ...
4 years, 9 months ago (2016-03-11 12:23:20 UTC) #3
ulan
lgtm
4 years, 9 months ago (2016-03-11 13:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783313003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783313003/80001
4 years, 9 months ago (2016-03-11 13:16:30 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-11 13:26:30 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 13:28:06 UTC) #9
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/c0d8036e913b91664093700b07f48e744e2b4335
Cr-Commit-Position: refs/heads/master@{#34722}

Powered by Google App Engine
This is Rietveld 408576698