Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/heap/heap-inl.h

Issue 1783313003: [heap] Use struct Entry to fill inlined promotion queue entries. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HEAP_HEAP_INL_H_ 5 #ifndef V8_HEAP_HEAP_INL_H_
6 #define V8_HEAP_HEAP_INL_H_ 6 #define V8_HEAP_HEAP_INL_H_
7 7
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "src/base/platform/platform.h" 10 #include "src/base/platform/platform.h"
11 #include "src/counters.h" 11 #include "src/counters.h"
12 #include "src/heap/heap.h" 12 #include "src/heap/heap.h"
13 #include "src/heap/incremental-marking-inl.h" 13 #include "src/heap/incremental-marking-inl.h"
14 #include "src/heap/mark-compact.h" 14 #include "src/heap/mark-compact.h"
15 #include "src/heap/spaces-inl.h" 15 #include "src/heap/spaces-inl.h"
16 #include "src/heap/store-buffer.h" 16 #include "src/heap/store-buffer.h"
17 #include "src/heap/store-buffer-inl.h" 17 #include "src/heap/store-buffer-inl.h"
18 #include "src/isolate.h" 18 #include "src/isolate.h"
19 #include "src/list-inl.h" 19 #include "src/list-inl.h"
20 #include "src/log.h" 20 #include "src/log.h"
21 #include "src/msan.h" 21 #include "src/msan.h"
22 #include "src/objects-inl.h" 22 #include "src/objects-inl.h"
23 #include "src/type-feedback-vector-inl.h" 23 #include "src/type-feedback-vector-inl.h"
24 24
25 namespace v8 { 25 namespace v8 {
26 namespace internal { 26 namespace internal {
27 27
28 void PromotionQueue::insert(HeapObject* target, int size) { 28 void PromotionQueue::insert(HeapObject* target, intptr_t size) {
29 if (emergency_stack_ != NULL) { 29 if (emergency_stack_ != NULL) {
30 emergency_stack_->Add(Entry(target, size)); 30 emergency_stack_->Add(Entry(target, size));
31 return; 31 return;
32 } 32 }
33 33
34 if ((rear_ - 2) < limit_) { 34 if ((rear_ - 1) < limit_) {
35 RelocateQueueHead(); 35 RelocateQueueHead();
36 emergency_stack_->Add(Entry(target, size)); 36 emergency_stack_->Add(Entry(target, size));
37 return; 37 return;
38 } 38 }
39 39
40 *(--rear_) = reinterpret_cast<intptr_t>(target); 40 struct Entry* entry = reinterpret_cast<struct Entry*>(--rear_);
41 *(--rear_) = size; 41 entry->obj_ = target;
42 entry->size_ = size;
43
42 // Assert no overflow into live objects. 44 // Assert no overflow into live objects.
43 #ifdef DEBUG 45 #ifdef DEBUG
44 SemiSpace::AssertValidRange(target->GetIsolate()->heap()->new_space()->top(), 46 SemiSpace::AssertValidRange(target->GetIsolate()->heap()->new_space()->top(),
45 reinterpret_cast<Address>(rear_)); 47 reinterpret_cast<Address>(rear_));
46 #endif 48 #endif
47 } 49 }
48 50
49 51
50 #define ROOT_ACCESSOR(type, name, camel_name) \ 52 #define ROOT_ACCESSOR(type, name, camel_name) \
51 type* Heap::name() { return type::cast(roots_[k##camel_name##RootIndex]); } 53 type* Heap::name() { return type::cast(roots_[k##camel_name##RootIndex]); }
(...skipping 681 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 735
734 void VerifySmisVisitor::VisitPointers(Object** start, Object** end) { 736 void VerifySmisVisitor::VisitPointers(Object** start, Object** end) {
735 for (Object** current = start; current < end; current++) { 737 for (Object** current = start; current < end; current++) {
736 CHECK((*current)->IsSmi()); 738 CHECK((*current)->IsSmi());
737 } 739 }
738 } 740 }
739 } // namespace internal 741 } // namespace internal
740 } // namespace v8 742 } // namespace v8
741 743
742 #endif // V8_HEAP_HEAP_INL_H_ 744 #endif // V8_HEAP_HEAP_INL_H_
OLDNEW
« no previous file with comments | « src/heap/heap.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698