Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1783303002: Revert of Capability Classes (Closed)

Created:
4 years, 9 months ago by vasilii
Modified:
4 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@45class
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Capability Classes (patchset #8 id:140001 of https://codereview.chromium.org/1781913003/ ) Reason for revert: Broke mojo_shell_unittests on Linux Tests (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/38823/steps/mojo_shell_unittests/logs/stdio) [ RUN ] ConnectTest.CapabilityClasses [0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter prevented binding to interface: mojo::shell::test::mojom::BlockedInterface connection_name:mojo:connect_test_app remote_name:mojo:connect_unittests [0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter prevented binding to interface: mojo::shell::test::mojom::ConnectTestService connection_name:mojo:connect_test_class_app remote_name:mojo:connect_test_app [0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter prevented binding to interface: mojo::shell::test::mojom::ClassInterface connection_name:mojo:connect_test_class_app remote_name:mojo:connect_test_app [ERROR:child_process_base.cc(212)] Connection error to the shell. [ERROR:child_process_base.cc(212)] Connection error to the shell. [37/37] ConnectTest.CapabilityClasses (TIMED OUT) Original issue's description: > Implement capability classes: > > - pass the union of the interfaces in the "interfaces" list of the capability request and the interfaces implied by all classes present in the request > - pass the class names so they can be used for non-interface capability granting > > R=sky@chromium.org > BUG= > > Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea > Cr-Commit-Position: refs/heads/master@{#380552} TBR=sky@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/52113dcdd7f4d22bb935a2681b1b385e367136df Cr-Commit-Position: refs/heads/master@{#380595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -275 lines) Patch
M mojo/shell/public/cpp/connection.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 4 chunks +2 lines, -4 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M mojo/shell/public/cpp/lib/connector_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell.cc View 5 chunks +14 lines, -32 lines 0 comments Download
M mojo/shell/tests/connect/BUILD.gn View 2 chunks +0 lines, -21 lines 0 comments Download
M mojo/shell/tests/connect/connect_test.mojom View 1 chunk +2 lines, -15 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app.cc View 2 chunks +0 lines, -33 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app_manifest.json View 1 chunk +1 line, -5 lines 0 comments Download
D mojo/shell/tests/connect/connect_test_class_app.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D mojo/shell/tests/connect/connect_test_class_app_manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/shell/tests/connect/connect_unittest.cc View 10 chunks +13 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vasilii
Created Revert of Capability Classes
4 years, 9 months ago (2016-03-11 10:44:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783303002/1
4 years, 9 months ago (2016-03-11 10:44:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 10:45:11 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 10:46:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52113dcdd7f4d22bb935a2681b1b385e367136df
Cr-Commit-Position: refs/heads/master@{#380595}

Powered by Google App Engine
This is Rietveld 408576698