Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(49)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: mojo/shell/tests/connect/connect_test_app_manifest.json
Issue
1783303002
:
Revert of Capability Classes (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@45class
Patch Set:
Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
mojo/shell/public/cpp/connection.h
mojo/shell/public/cpp/lib/connection_impl.h
mojo/shell/public/cpp/lib/connection_impl.cc
mojo/shell/public/cpp/lib/connector_impl.cc
mojo/shell/public/cpp/lib/shell_connection.cc
mojo/shell/shell.cc
mojo/shell/tests/connect/BUILD.gn
mojo/shell/tests/connect/connect_test.mojom
mojo/shell/tests/connect/connect_test_app.cc
mojo/shell/tests/connect/connect_test_app_manifest.json
mojo/shell/tests/connect/connect_test_class_app.cc
mojo/shell/tests/connect/connect_test_class_app_manifest.json
mojo/shell/tests/connect/connect_unittest.cc
View unified diff
|
Download patch
« no previous file with comments
|
« mojo/shell/tests/connect/connect_test_app.cc
('k') |
mojo/shell/tests/connect/connect_test_class_app.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 {
1 {
2 "manifest_version": 1,
2 "manifest_version": 1,
3 "name": "mojo:connect_test_app",
3 "name": "mojo:connect_test_app",
4 "display_name": "Connect Test App",
4 "display_name": "Connect Test App",
5 "capabilities": {
5 "capabilities": {
6 "required": {
6 "required": {
7
"mojo:connect_test_a": { "interfaces": ["*"] }
,
7
"mojo:connect_test_a": { "interfaces": ["*"] }
8
"mojo:connect_test_class_app": {
9
"classes": ["class"],
10
"interfaces": ["mojo.shell.test.mojom.ConnectTestService"]
11
}
12 }
8 }
13 }
9 }
14 }
10 }
OLD
NEW
« no previous file with comments
|
« mojo/shell/tests/connect/connect_test_app.cc
('k') |
mojo/shell/tests/connect/connect_test_class_app.cc »
('j') |
no next file with comments »
Issue 1783303002: Revert of Capability Classes (Closed)
Created 4 years, 9 months ago by vasilii
Modified 4 years, 9 months ago
Reviewers: sky, Ben Goodger (Google)
Base URL: https://chromium.googlesource.com/chromium/src.git@45class
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 1783303002:
Revert of Capability Classes (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@45class