Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 1783283004: Update V8 to version 5.1.115. (Closed)

Created:
4 years, 9 months ago by v8-autoroll
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 5.1.115. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a09b4096..235b98f3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Committed: https://crrev.com/15e94e2a8ea96963f9638f1abec11d4eb55869c8 Cr-Commit-Position: refs/heads/master@{#380727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
v8-autoroll
4 years, 9 months ago (2016-03-11 17:32:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783283004/1
4 years, 9 months ago (2016-03-11 17:33:22 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129846)
4 years, 9 months ago (2016-03-11 19:28:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783283004/1
4 years, 9 months ago (2016-03-11 19:31:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 21:06:26 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/15e94e2a8ea96963f9638f1abec11d4eb55869c8 Cr-Commit-Position: refs/heads/master@{#380727}
4 years, 9 months ago (2016-03-11 21:07:30 UTC) #10
alexmos
4 years, 9 months ago (2016-03-11 22:02:34 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1788763004/ by alexmos@chromium.org.

The reason for reverting is: Broke compile on WebKit Linux MSAN:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...

The culprit v8 CL is https://codereview.chromium.org/1783313003.

Output from failed bot: 
... ../../v8/src/heap/heap.cc -o obj/v8/src/heap/v8_base.heap.o
../../v8/src/heap/heap.cc:1588:54: error: use of undeclared identifier 'size';
did you mean 'ConstantPoolEntry::size'?
    MSAN_MEMORY_IS_INITIALIZED(&entry->size_, sizeof(size));
                                                     ^~~~
                                                     ConstantPoolEntry::size
../../v8/src/msan.h:27:64: note: expanded from macro
'MSAN_MEMORY_IS_INITIALIZED'
#define MSAN_MEMORY_IS_INITIALIZED(p, s) __msan_unpoison((p), (s))
                                                               ^
../../v8/src/assembler.h:1222:14: note: 'ConstantPoolEntry::size' declared here
  static int size(Type type) {
             ^
../../v8/src/heap/heap.cc:1588:53: error: invalid application of 'sizeof' to a
function type
    MSAN_MEMORY_IS_INITIALIZED(&entry->size_, sizeof(size));
                                                    ^~~~~~
../../v8/src/msan.h:27:64: note: expanded from macro
'MSAN_MEMORY_IS_INITIALIZED'
#define MSAN_MEMORY_IS_INITIALIZED(p, s) __msan_unpoison((p), (s))
                                                               ^
../../v8/src/heap/heap.cc:1589:53: error: use of undeclared identifier 'obj'
    MSAN_MEMORY_IS_INITIALIZED(&entry->obj_, sizeof(obj));
.

Powered by Google App Engine
This is Rietveld 408576698