Source/core/rendering/compositing/RenderLayerCompositor.h - Issue 178313004: Remove the HashMap in RenderLayerCompositor's overlap map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.h

Issue 178313004: Remove the HashMap in RenderLayerCompositor's overlap map (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/compositing/layer-creation/overlap-transformed-layer-with-tranform-body-expected.txt ('K') | « LayoutTests/compositing/layer-creation/overlap-transformed-layer-with-tranform-body-expected.txt ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/RenderLayerCompositor.h

diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.h b/Source/core/rendering/compositing/RenderLayerCompositor.h

index 0987c3b32332850fc2fc61979a06da49bb304598..639457f0f92dbbb5c42712088e0880df6358a481 100644

--- a/Source/core/rendering/compositing/RenderLayerCompositor.h

+++ b/Source/core/rendering/compositing/RenderLayerCompositor.h

@@ -264,15 +264,14 @@ private:

// Repaint the given rect (which is layer's coords), and regions of child layers that intersect that rect.

void recursiveRepaintLayer(RenderLayer*, const IntRect* = 0);

- void addToOverlapMap(OverlapMap&, RenderLayer*, IntRect& layerBounds, bool& boundsComputed);

- void addToOverlapMapRecursive(OverlapMap&, RenderLayer*, RenderLayer* ancestorLayer = 0);

+ void addToOverlapMap(OverlapMap&, RenderLayer*, IntRect& layerBounds);

// Forces an update for all frames of frame tree recursively. Used only when the mainFrame compositor is ready to

// finish all deferred work.

static void finishCompositingUpdateForFrameTree(LocalFrame*);

- // Returns true if any layer's compositing changed

enne (OOO) 2014/02/28 00:50:13 This is why we can't have nice comments!!

- void computeCompositingRequirements(RenderLayer* ancestorLayer, RenderLayer*, OverlapMap*, struct CompositingRecursionData&, bool& descendantHas3DTransform, Vector<RenderLayer*>& unclippedDescendants);

+ // Returns an absolute bounding box for the layer's decendants.

+ IntRect computeCompositingRequirements(RenderLayer* ancestorLayer, RenderLayer*, OverlapMap*, struct CompositingRecursionData&, bool& descendantHas3DTransform, Vector<RenderLayer*>& unclippedDescendants);

// Defines which RenderLayers will paint into which composited backings, by allocating and destroying CompositedLayerMappings as needed.

void assignLayersToBackings(RenderLayer*, bool& layersChanged);