core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp - Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp ('K') | « core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp ('k') | core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp » ('j') | core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp b/core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

index b414827f95eb84c2e7e38c105e26c1ff52d2276e..89ad5eec33dbc5330e3eb9c02b71f0d6cc07c4bf 100644

--- a/core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

+++ b/core/src/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

@@ -772,7 +772,8 @@ CPDF_Stream* CPDF_SyntaxParser::ReadStream(CPDF_Dictionary* pDict,

GetNextWordInternal(nullptr);

int numMarkers = ReadEOLMarkers(m_Pos);

- if (m_WordSize == kEndObjStr.GetLength() && numMarkers != 0 &&

+ if (m_WordSize == static_cast<unsigned int>(kEndObjStr.GetLength()) &&

+ numMarkers != 0 &&

FXSYS_memcmp(m_WordBuffer, kEndObjStr.GetPtr(), kEndObjStr.GetLength()) ==

0) {

m_Pos = streamStartPos;