Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp

Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp
diff --git a/core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp b/core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp
index feb152ba4a6db8c223a65b8d69751633f55b0865..30c494aca5b8409ca89d43f5ee4d8b3403818c0c 100644
--- a/core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp
+++ b/core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp
@@ -383,7 +383,7 @@ FX_BOOL CPDF_StandardSecurityHandler::AES256_CheckPassword(
if (buf[9] != 'a' || buf[10] != 'd' || buf[11] != 'b') {
return FALSE;
}
- if (FXDWORD_GET_LSBFIRST(buf) != m_Permissions) {
+ if (FXDWORD_GET_LSBFIRST(buf) != static_cast<int>(m_Permissions)) {
Tom Sepez 2016/03/11 00:30:28 I'd really like the return vale of FXDWORD_GET_LS
Wei Li 2016/03/11 04:11:36 Done.
return FALSE;
}
if ((buf[8] == 'T' && !IsMetadataEncrypted()) ||

Powered by Google App Engine
This is Rietveld 408576698