core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp - Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp ('K') | « core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp ('k') | core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp » ('j') | core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp b/core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

index c9a2d8d496dec9babe811fd66ade0ac84e43b911..daf416ee2dc4f88b267414bcd38258d8a2870b1e 100644

--- a/core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

+++ b/core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

@@ -124,7 +124,7 @@ void CPDF_Parser::ShrinkObjectMap(FX_DWORD objnum) {

}

void CPDF_Parser::CloseParser() {

- m_bVersionUpdated = FALSE;

+ m_bVersionUpdated = false;

delete m_pDocument;

m_pDocument = nullptr;

@@ -466,7 +466,7 @@ FX_BOOL CPDF_Parser::LoadLinearizedCrossRefV4(FX_FILESIZE pos,

m_ObjectInfo[objnum].pos = offset;

int32_t version = FXSYS_atoi(pEntry + 11);

if (version >= 1)

- m_bVersionUpdated = TRUE;

+ m_bVersionUpdated = true;

m_ObjectInfo[objnum].gennum = version;

if (m_ObjectInfo[objnum].pos < m_pSyntax->m_FileLen)

@@ -541,7 +541,7 @@ bool CPDF_Parser::LoadCrossRefV4(FX_FILESIZE pos,

m_ObjectInfo[objnum].pos = offset;

int32_t version = FXSYS_atoi(pEntry + 11);

if (version >= 1)

- m_bVersionUpdated = TRUE;

+ m_bVersionUpdated = true;

m_ObjectInfo[objnum].gennum = version;

if (m_ObjectInfo[objnum].pos < m_pSyntax->m_FileLen)

@@ -775,7 +775,7 @@ FX_BOOL CPDF_Parser::RebuildCrossRef() {

m_ObjectInfo[objnum].pos = obj_pos;

m_ObjectInfo[objnum].gennum = gennum;

if (oldgen != gennum)

- m_bVersionUpdated = TRUE;

+ m_bVersionUpdated = true;

}

} else {

m_ObjectInfo[objnum].pos = obj_pos;