core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp - Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp

Issue 1783023002: Re-enable MSVC warning 4800 for compiling with chromium_code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« core/include/fxcrt/fx_ext.h ('K') | « core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp ('k') | core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp » ('j') | core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp b/core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp

index 6256f4c526b273f0b0e543e97a4a4e657bd67ab1..1d6e9a27109f3eec4af7d1c22132e6ab3d01b86e 100644

--- a/core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp

+++ b/core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp

@@ -267,7 +267,7 @@ FX_BOOL CPDF_HintTables::ReadSharedObjHintTable(CFX_BitStream* hStream,

if (!CanReadFromBitStream(hStream, required_bits))

return FALSE;

- for (int i = 0; i < dwSharedObjTotal; ++i) {

+ for (size_t i = 0; i < dwSharedObjTotal; ++i) {

Tom Sepez 2016/03/11 00:30:28 nit: how about FX_DWORD, to match the type of dwSh

Wei Li 2016/03/11 04:11:36 Done.

dwPrevObjLen = dwCurObjLen;

FX_SAFE_DWORD safeObjLen = hStream->GetBits(dwDeltaGroupLen);

safeObjLen += dwGroupLeastLen;