Chromium Code Reviews
Help | Chromium Project | Sign in
(453)

Issue 1783008: Cleanup: Remove the implicit constructor for BoundNetLog that allowed passing... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 12 months ago by eroman
Modified:
2 years, 10 months ago
CC:
chromium-reviews_chromium.org, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Cleanup: Remove the implicit constructor for BoundNetLog that allowed passing NULL in place of a const BoundNetLog&.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45851

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : fix indentation #

Patch Set 4 : misc other fixes (indentation, comment, missing file) #

Patch Set 5 : add another missing file #

Total comments: 4

Patch Set 6 : Address cbentzel's comments #

Patch Set 7 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -410 lines) Lint Patch
M chrome/browser/net/resolve_proxy_msg_helper.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/base/host_resolver_impl_unittest.cc View 1 2 3 4 5 6 19 chunks +26 lines, -20 lines 0 comments 0 errors Download
M net/base/net_log.h View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments 0 errors Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments 0 errors Download
M net/http/http_auth_handler_negotiate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M net/http/http_cache.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/http/http_cache_unittest.cc View 1 2 3 4 5 6 26 chunks +28 lines, -28 lines 0 comments 0 errors Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 4 5 6 74 chunks +74 lines, -74 lines 0 comments 0 errors Download
M net/proxy/init_proxy_resolver.h View 1 2 3 4 5 6 2 chunks +4 lines, -5 lines 0 comments 0 errors Download
M net/proxy/init_proxy_resolver.cc View 1 2 3 4 5 6 2 chunks +6 lines, -7 lines 0 comments 0 errors Download
M net/proxy/init_proxy_resolver_unittest.cc View 1 2 3 4 5 6 10 chunks +23 lines, -23 lines 0 comments 0 errors Download
M net/proxy/proxy_resolver_perftest.cc View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments 0 errors Download
M net/proxy/proxy_resolver_v8.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/proxy/proxy_resolver_v8_unittest.cc View 1 2 3 4 5 6 16 chunks +35 lines, -18 lines 0 comments 0 errors Download
M net/proxy/proxy_service.h View 1 2 3 4 5 6 2 chunks +6 lines, -3 lines 0 comments 0 errors Download
M net/proxy/proxy_service.cc View 1 2 3 4 5 6 6 chunks +9 lines, -9 lines 0 comments 0 errors Download
M net/proxy/proxy_service_unittest.cc View 1 2 3 4 5 6 67 chunks +126 lines, -102 lines 0 comments 0 errors Download
M net/proxy/single_threaded_proxy_resolver_unittest.cc View 1 2 3 4 5 6 6 chunks +12 lines, -12 lines 0 comments 0 errors Download
M net/socket/client_socket_pool_base_unittest.cc View 1 2 3 4 5 6 19 chunks +44 lines, -29 lines 0 comments 0 errors Download
M net/socket/socket_test_util.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/socket/socks5_client_socket_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M net/socket/socks_client_socket_pool_unittest.cc View 1 2 3 4 5 6 6 chunks +9 lines, -6 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_unittest.cc View 1 2 3 4 5 6 7 chunks +7 lines, -7 lines 0 comments 0 errors Download
M net/socket/ssl_test_util.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/socket/tcp_client_socket_pool_unittest.cc View 1 2 3 4 5 6 13 chunks +24 lines, -16 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/socket/tcp_pinger_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 4 5 6 22 chunks +34 lines, -22 lines 0 comments 0 errors Download
M net/spdy/spdy_session.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/spdy/spdy_session_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/spdy/spdy_stream_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M net/tools/fetch/fetch_client.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/tools/hresolv/hresolv.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments 0 errors Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 5 6 1 chunk +2 lines, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 4
eroman
3 years, 12 months ago #1
cbentzel (out until April 27)
LGTM Drive-by comments. http://codereview.chromium.org/1783008/diff/12004/62006 File net/http/http_cache.cc (right): http://codereview.chromium.org/1783008/diff/12004/62006#newcode166 net/http/http_cache.cc:166: int rv = transaction_->Start(&request_info_, &callback_, BoundNetLog()); ...
3 years, 12 months ago #2
willchan
LGTM
3 years, 12 months ago #3
eroman
3 years, 12 months ago #4
http://codereview.chromium.org/1783008/diff/12004/62006
File net/http/http_cache.cc (right):

http://codereview.chromium.org/1783008/diff/12004/62006#newcode166
net/http/http_cache.cc:166: int rv = transaction_->Start(&request_info_,
&callback_, BoundNetLog());
On 2010/04/28 14:21:15, cbentzel wrote:
> In this case, should you change HttpCache::WriteMetadata to take a
BoundNetLog()
> (and pass it in to the HttpCache::MetadataWriter)? 
> 
> It looks like the primary user of this is HttpCache::Transaction, which will
> have a BoundNetLog. The unit tests which call this can just construct a
default
> one like all of the other changes you've made to unit tests.
> 

Agreed.

HttpCache needs some more work so it logs information about all of its internal
transaction (like any if-modified-since it runs).

That is outside of the scope of this cleanup however, but thanks for pointing it
out.

http://codereview.chromium.org/1783008/diff/12004/62009
File net/proxy/proxy_service.h (right):

http://codereview.chromium.org/1783008/diff/12004/62009#newcode40
net/proxy/proxy_service.h:40: // with it to detect when the network setup has
changed. This is used to
On 2010/04/28 14:21:15, cbentzel wrote:
> Nit: Document lifetime/ownership expectations of net_log

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6