net/ftp/ftp_network_transaction_unittest.cc - Issue 1783008: Cleanup: Remove the implicit constructor for BoundNetLog that allowed passing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_network_transaction_unittest.cc

Issue 1783008: Cleanup: Remove the implicit constructor for BoundNetLog that allowed passing... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Sync Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ftp/ftp_network_transaction_unittest.cc

===================================================================

--- net/ftp/ftp_network_transaction_unittest.cc (revision 45843)

+++ net/ftp/ftp_network_transaction_unittest.cc (working copy)

@@ -715,7 +715,7 @@

FtpRequestInfo request_info = GetRequestInfo(request);

EXPECT_EQ(LOAD_STATE_IDLE, transaction_.GetLoadState());

ASSERT_EQ(ERR_IO_PENDING,

- transaction_.Start(&request_info, &callback_, NULL));

+ transaction_.Start(&request_info, &callback_, BoundNetLog()));

EXPECT_NE(LOAD_STATE_IDLE, transaction_.GetLoadState());

ASSERT_EQ(expected_result, callback_.WaitForResult());

if (expected_result == OK) {

@@ -761,7 +761,7 @@

host_resolver_->rules()->AddSimulatedFailure("badhost");

EXPECT_EQ(LOAD_STATE_IDLE, transaction_.GetLoadState());

ASSERT_EQ(ERR_IO_PENDING,

- transaction_.Start(&request_info, &callback_, NULL));

+ transaction_.Start(&request_info, &callback_, BoundNetLog()));

ASSERT_EQ(ERR_NAME_NOT_RESOLVED, callback_.WaitForResult());

EXPECT_EQ(LOAD_STATE_IDLE, transaction_.GetLoadState());

}

@@ -962,7 +962,7 @@

// Start the transaction.

ASSERT_EQ(ERR_IO_PENDING,

- transaction_.Start(&request_info, &callback_, NULL));

+ transaction_.Start(&request_info, &callback_, BoundNetLog()));

ASSERT_EQ(OK, callback_.WaitForResult());

// The transaction fires the callback when we can start reading data. That

@@ -1085,7 +1085,7 @@

FtpRequestInfo request_info = GetRequestInfo("ftp://host/file");

ASSERT_EQ(ERR_IO_PENDING,

- transaction_.Start(&request_info, &callback_, NULL));

+ transaction_.Start(&request_info, &callback_, BoundNetLog()));

ASSERT_EQ(ERR_FAILED, callback_.WaitForResult());

MockRead ctrl_reads[] = {

@@ -1115,7 +1115,7 @@

FtpRequestInfo request_info = GetRequestInfo("ftp://host/file");

ASSERT_EQ(ERR_IO_PENDING,

- transaction_.Start(&request_info, &callback_, NULL));

+ transaction_.Start(&request_info, &callback_, BoundNetLog()));

ASSERT_EQ(ERR_FAILED, callback_.WaitForResult());

MockRead ctrl_reads[] = {

« no previous file with comments | « net/base/net_log.h ('k') | net/http/http_auth_handler_negotiate_unittest.cc » ('j') | no next file with comments »