Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: src/frames.cc

Issue 1782613003: [wasm] GC should ignore unboxed stack parameters in WASM frames. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/wasm/gc-frame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 362ae89399e977b646f3b4ab0fd33182c63a1670..67a03081e5045a826e08f55454ee9620d2c0b269 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -743,7 +743,10 @@ void StandardFrame::IterateCompiledFrame(ObjectVisitor* v) const {
safepoint_bits += kNumSafepointRegisters >> kBitsPerByteLog2;
// Visit the rest of the parameters.
- v->VisitPointers(parameters_base, parameters_limit);
+ if (!is_js_to_wasm() && !is_wasm()) {
+ // Non-WASM frames have tagged values as parameters.
+ v->VisitPointers(parameters_base, parameters_limit);
+ }
// Visit pointer spill slots and locals.
for (unsigned index = 0; index < stack_slots; index++) {
« no previous file with comments | « no previous file | test/mjsunit/wasm/gc-frame.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698