Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Side by Side Diff: src/frames.cc

Issue 1782613003: [wasm] GC should ignore unboxed stack parameters in WASM frames. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/wasm/gc-frame.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/frames.h" 5 #include "src/frames.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/ast/scopeinfo.h" 10 #include "src/ast/scopeinfo.h"
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 } 736 }
737 // Skip the words containing the register values. 737 // Skip the words containing the register values.
738 parameters_base += kNumSafepointRegisters; 738 parameters_base += kNumSafepointRegisters;
739 } 739 }
740 740
741 // We're done dealing with the register bits. 741 // We're done dealing with the register bits.
742 uint8_t* safepoint_bits = safepoint_entry.bits(); 742 uint8_t* safepoint_bits = safepoint_entry.bits();
743 safepoint_bits += kNumSafepointRegisters >> kBitsPerByteLog2; 743 safepoint_bits += kNumSafepointRegisters >> kBitsPerByteLog2;
744 744
745 // Visit the rest of the parameters. 745 // Visit the rest of the parameters.
746 v->VisitPointers(parameters_base, parameters_limit); 746 if (!is_js_to_wasm() && !is_wasm()) {
747 // Non-WASM frames have tagged values as parameters.
748 v->VisitPointers(parameters_base, parameters_limit);
749 }
747 750
748 // Visit pointer spill slots and locals. 751 // Visit pointer spill slots and locals.
749 for (unsigned index = 0; index < stack_slots; index++) { 752 for (unsigned index = 0; index < stack_slots; index++) {
750 int byte_index = index >> kBitsPerByteLog2; 753 int byte_index = index >> kBitsPerByteLog2;
751 int bit_index = index & (kBitsPerByte - 1); 754 int bit_index = index & (kBitsPerByte - 1);
752 if ((safepoint_bits[byte_index] & (1U << bit_index)) != 0) { 755 if ((safepoint_bits[byte_index] & (1U << bit_index)) != 0) {
753 v->VisitPointer(parameters_limit + index); 756 v->VisitPointer(parameters_limit + index);
754 } 757 }
755 } 758 }
756 759
(...skipping 955 matching lines...) Expand 10 before | Expand all | Expand 10 after
1712 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) { 1715 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
1713 StackFrame* frame = AllocateFrameCopy(it.frame(), zone); 1716 StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
1714 list.Add(frame, zone); 1717 list.Add(frame, zone);
1715 } 1718 }
1716 return list.ToVector(); 1719 return list.ToVector();
1717 } 1720 }
1718 1721
1719 1722
1720 } // namespace internal 1723 } // namespace internal
1721 } // namespace v8 1724 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/wasm/gc-frame.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698