Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1782613003: [wasm] GC should ignore unboxed stack parameters in WASM frames. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] GC should ignore unboxed stack parameters in WASM frames. R=mstarzinger@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/a42b24514e4b75b74439b6bca1c11840f3516b9a Cr-Commit-Position: refs/heads/master@{#34682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -1 line) Patch
M src/frames.cc View 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/wasm/gc-frame.js View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 9 months ago (2016-03-10 14:43:33 UTC) #1
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-10 15:11:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782613003/1
4 years, 9 months ago (2016-03-10 15:11:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 15:13:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a42b24514e4b75b74439b6bca1c11840f3516b9a Cr-Commit-Position: refs/heads/master@{#34682}
4 years, 9 months ago (2016-03-10 15:15:06 UTC) #7
bradn
4 years, 9 months ago (2016-03-10 17:15:26 UTC) #9
Message was sent while issue was closed.
Ah, the other direction. Hah. LGTM

Powered by Google App Engine
This is Rietveld 408576698